From: patchwork-bot+linux-amlogic@kernel.org
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: linux-amlogic@lists.infradead.org, khilman@kernel.org
Subject: Re: [PATCH] usb: dwc3: meson-g12a: Don't use ret uninitialized in dwc3_meson_g12a_otg_init
Date: Thu, 16 Apr 2020 16:08:02 +0000 [thread overview]
Message-ID: <158705328211.8629.9063413018389670651.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20200210225816.36598-1-natechancellor@gmail.com>
Hello:
This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next).
On Mon, 10 Feb 2020 15:58:17 -0700 you wrote:
> Clang warns:
>
> ../drivers/usb/dwc3/dwc3-meson-g12a.c:421:6: warning: variable 'ret' is
> used uninitialized whenever 'if' condition is false
> [-Wsometimes-uninitialized]
> if (priv->otg_mode == USB_DR_MODE_OTG) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/usb/dwc3/dwc3-meson-g12a.c:455:9: note: uninitialized use
> occurs here
> return ret;
> ^~~
> ../drivers/usb/dwc3/dwc3-meson-g12a.c:421:2: note: remove the 'if' if
> its condition is always true
> if (priv->otg_mode == USB_DR_MODE_OTG) {
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../drivers/usb/dwc3/dwc3-meson-g12a.c:415:9: note: initialize the
> variable 'ret' to silence this warning
> int ret, irq;
> ^
> = 0
> 1 warning generated.
>
> [...]
Here is a summary with links:
- usb: dwc3: meson-g12a: Don't use ret uninitialized in dwc3_meson_g12a_otg_init
https://git.kernel.org/khilman/linux-amlogic/c/238d760216541d345ee930e76c781f5cd1d22fba
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2020-04-16 16:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 22:58 [PATCH] usb: dwc3: meson-g12a: Don't use ret uninitialized in dwc3_meson_g12a_otg_init Nathan Chancellor
2020-02-19 14:14 ` Neil Armstrong
2020-04-16 16:08 ` patchwork-bot+linux-amlogic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158705328211.8629.9063413018389670651.git-patchwork-notify@kernel.org \
--to=patchwork-bot+linux-amlogic@kernel.org \
--cc=khilman@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).