From: Alexander Stein <alexander.stein@mailbox.org>
To: Rob Herring <robh+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/1] arm64: dts: meson: g12b: odroid-n2: Assign a fixed index to mmc devices
Date: Fri, 29 Jan 2021 21:51:01 +0100 [thread overview]
Message-ID: <1975982.ltkoRUPMKj@kongar> (raw)
In-Reply-To: <8de4d82e-b9a5-f809-ea67-5527f9fdde5f@baylibre.com>
Hi,
Am Freitag, 29. Januar 2021, 09:07:45 CET schrieb Neil Armstrong:
> On 28/01/2021 00:08, Alexander Stein wrote:
> > Recently introduced async probe on mmc devices can shuffle block IDs.
> > Pin them to fixed values to ease booting in environments where UUIDs
> > are not practical. Use newly introduced aliases for mmcblk devices from
[1].
> > [1]
> > https://patchwork.kernel.org/patch/11747669/
>
> I understand the goal, and this should be done for _all_ boards, not only
the Odroid-N2.
I see. So there are 2 options:
1.
Set the mapping for all 3 sd_emmc_* in the top-most .dtsi
Upside: very easy patch
Downside: When sd_emmc_a is not enabled "mmc0" will never be available.
Might be confusing.
2.
Set mapping only for enabled sd_emmc_* in the .dts[i] where it is enabled
Upside: Clean setup, only enabled sd_emmc_* have an alias
Downside: Much verbose patch(set)
Any preferences here? I honestly tend to 1. But this might break boards where
sd_emmc_a is not enabled, because the root device _will_ change in that case.
Best regards,
Alexander
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-01-29 20:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 23:08 [PATCH 1/1] arm64: dts: meson: g12b: odroid-n2: Assign a fixed index to mmc devices Alexander Stein
2021-01-29 8:07 ` Neil Armstrong
2021-01-29 20:51 ` Alexander Stein [this message]
2021-02-02 0:50 ` Kevin Hilman
2021-02-02 17:03 ` [PATCH v2 1/1] arm64: dts: amlogic: " Alexander Stein
2021-02-03 19:20 ` Kevin Hilman
2021-02-03 19:28 ` [PATCH v3 " Alexander Stein
2021-02-18 18:09 ` Alexander Stein
2021-03-08 17:43 ` Kevin Hilman
2021-10-02 6:56 ` Alexander Stein
2021-10-02 8:49 ` Neil Armstrong
2021-10-02 8:54 ` Alexander Stein
2021-03-08 17:39 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1975982.ltkoRUPMKj@kongar \
--to=alexander.stein@mailbox.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).