From: Jerome Brunet <jbrunet@baylibre.com>
To: Qianggui Song <qianggui.song@amlogic.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Hanjie Lin <hanjie.lin@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
Xingyu Chen <xingyu.chen@amlogic.com>
Subject: Re: [PATCH v3 2/4] pinctrl: meson: add a new dt parse callback for Meson-A series SoCs
Date: Wed, 23 Oct 2019 14:58:29 +0200 [thread overview]
Message-ID: <1j1rv3vcsq.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <4e4aa76e-d315-2b99-91f4-6667eb5221e7@amlogic.com>
On Wed 23 Oct 2019 at 14:33, Qianggui Song <qianggui.song@amlogic.com> wrote:
> On 2019/10/23 17:01, Jerome Brunet wrote:
>>
>> On Mon 14 Oct 2019 at 12:54, Qianggui Song <qianggui.song@amlogic.com> wrote:
>>
>>>
>>> diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
>>> index 8bba9d053d9f..e8f6298fc96a 100644
>>> --- a/drivers/pinctrl/meson/pinctrl-meson.c
>>> +++ b/drivers/pinctrl/meson/pinctrl-meson.c
>>> @@ -695,6 +695,17 @@ static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc,
>>> return 0;
>>> }
>>>
>>> +int meson_pinctrl_parse_dt_extra(struct meson_pinctrl *pc,
>>> + struct device_node *node)
>>
>> This function is the fixup for the a1 family, AFAICT.
>> It should be named as such and it belong in pinctrl-meson-a1.c
>>
>> Every controller performing fixups should have their function as well:
>> (1) AO of gxbb, gxl and axg
>> (2) AO of g12 and sm
>>
> OK, Will try to move this function to pinctrl-meson-a1.c. That should be
> better than rewriting parse function for each chips EE/AO alone.
>>> +{
>>> + int ret;
>>> +
>>> + ret = meson_pinctrl_parse_dt(pc, node);
>>
>> As said in previous review, meson_pinctrl_parse_dt() should be called
>> for every SoC to parse the *available* regions.
>>
>> The fixup, if necessary, will be done by providing a callback
>>
>> IOW, please:
>> * rework meson_pinctrl_parse_dt() to only parse the avaialble region
>> * don't call meson_pinctrl_parse_dt() from the extra function
>> * provided the extra function for the AO controllers of the other SoCs
>>
> That means I need to move not only ao fixup but ds to extra function for
> old chips do not support this.But it will touch other Socs, should I do
> this in A1 pinctrl patchset? or do this rework in another patchset.
I don't there any problem doing in a single patchset.
For example, you can make a first that does the rework for the older SoCs
and add the "extra" mechanism then another one adding A1 support
>>> + pc->reg_ds = pc->reg_pullen;
>>> +
>>> + return ret;
>>> +}
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-10-23 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 10:54 [PATCH v3 0/4] pinctrl: meson-a1: add pinctrl driver Qianggui Song
2019-10-14 10:54 ` [PATCH v3 1/4] pinctrl: add compatible for Amlogic Meson A1 pin controller Qianggui Song
2019-10-14 10:54 ` [PATCH v3 2/4] pinctrl: meson: add a new dt parse callback for Meson-A series SoCs Qianggui Song
2019-10-23 9:01 ` Jerome Brunet
2019-10-23 12:33 ` Qianggui Song
2019-10-23 12:58 ` Jerome Brunet [this message]
2019-10-14 10:54 ` [PATCH v3 3/4] pinctrl: meson: add pinctrl driver support for Meson-A1 Soc Qianggui Song
2019-10-14 10:54 ` [PATCH v3 4/4] arm64: dts: meson: a1: add pinctrl controller support Qianggui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1j1rv3vcsq.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=carlo@caione.org \
--cc=hanjie.lin@amlogic.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=qianggui.song@amlogic.com \
--cc=robh+dt@kernel.org \
--cc=xingyu.chen@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).