From: Jerome Brunet <jbrunet@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org
Cc: sboyd@kernel.org, mturquette@baylibre.com,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] clk: meson: clk-pll: fix initializing the old rate (fallback) for a PLL
Date: Mon, 04 Jan 2021 12:43:11 +0100 [thread overview]
Message-ID: <1j35zhx700.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20201226121556.975418-2-martin.blumenstingl@googlemail.com>
On Sat 26 Dec 2020 at 13:15, Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> The "rate" parameter in meson_clk_pll_set_rate() contains the new rate.
> Retrieve the old rate with clk_hw_get_rate() so we don't inifinitely try
> to switch from the new rate to the same ratte again.
Small typo above fixed while applying
>
> Fixes: 7a29a869434e8b ("clk: meson: Add support for Meson clock controller")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> ---
> drivers/clk/meson/clk-pll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
> index b17a13e9337c..9404609b5ebf 100644
> --- a/drivers/clk/meson/clk-pll.c
> +++ b/drivers/clk/meson/clk-pll.c
> @@ -371,7 +371,7 @@ static int meson_clk_pll_set_rate(struct clk_hw *hw, unsigned long rate,
> if (parent_rate == 0 || rate == 0)
> return -EINVAL;
>
> - old_rate = rate;
> + old_rate = clk_hw_get_rate(hw);
>
> ret = meson_clk_get_pll_settings(rate, parent_rate, &m, &n, pll);
> if (ret)
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2021-01-04 11:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 12:15 [PATCH 0/3] clk: meson: three small clk-pll fixes Martin Blumenstingl
2020-12-26 12:15 ` [PATCH 1/3] clk: meson: clk-pll: fix initializing the old rate (fallback) for a PLL Martin Blumenstingl
2021-01-04 11:43 ` Jerome Brunet [this message]
2020-12-26 12:15 ` [PATCH 2/3] clk: meson: clk-pll: make "ret" a signed integer Martin Blumenstingl
2020-12-26 12:15 ` [PATCH 3/3] clk: meson: clk-pll: propagate the error from meson_clk_pll_set_rate() Martin Blumenstingl
2021-01-04 11:43 ` [PATCH 0/3] clk: meson: three small clk-pll fixes Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1j35zhx700.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).