From: Rob Herring <robh@kernel.org>
To: Carlo Caione <ccaione@baylibre.com>
Cc: devicetree@vger.kernel.org, narmstrong@baylibre.com,
khilman@baylibre.com, srinivas.kandagatla@linaro.org,
linux-amlogic@lists.infradead.org, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com
Subject: Re: [PATCH v2 2/4] nvmem: meson-efuse: bindings: Add secure-monitor phandle
Date: Wed, 21 Aug 2019 13:14:58 -0500 [thread overview]
Message-ID: <20190821181458.GA2886@bogus> (raw)
In-Reply-To: <20190731082339.20163-3-ccaione@baylibre.com>
On Wed, Jul 31, 2019 at 09:23:37AM +0100, Carlo Caione wrote:
> Add a new property to link the nvmem driver to the secure-monitor. The
> nvmem driver needs to access the secure-monitor to be able to access the
> fuses.
>
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
> Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt
> index 2e0723ab3384..f7b3ed74db54 100644
> --- a/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt
> +++ b/Documentation/devicetree/bindings/nvmem/amlogic-efuse.txt
> @@ -4,6 +4,7 @@ Required properties:
> - compatible: should be "amlogic,meson-gxbb-efuse"
> - clocks: phandle to the efuse peripheral clock provided by the
> clock controller.
> +- secure-monitor: phandle to the secure-monitor node
>
> = Data cells =
> Are child nodes of eFuse, bindings of which as described in
> @@ -16,6 +17,7 @@ Example:
> clocks = <&clkc CLKID_EFUSE>;
> #address-cells = <1>;
> #size-cells = <1>;
> + secure-monitor = <&sm>;
>
> sn: sn@14 {
> reg = <0x14 0x10>;
> @@ -30,6 +32,10 @@ Example:
> };
> };
>
> + sm: secure-monitor {
> + compatible = "amlogic,meson-gxbb-sm";
> + };
I guess I acked this a while back, but I'm not sure I would today. It
seems incomplete and a node with only a compatible string and no
resources doesn't need to be in DT. But that's already done...
There's no need for 'secure-monitor' anyways. Just do
'of_find_compatible_node(NULL, NULL, "amlogic,meson-gxbb-sm")' or search
for the driver directly. It's not like there's more than one secure
monitor...
Rob
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-08-21 18:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 8:23 [PATCH v2 0/4] Rework secure-monitor driver Carlo Caione
2019-07-31 8:23 ` [PATCH v2 1/4] firmware: meson_sm: Mark chip struct as static const Carlo Caione
2019-07-31 8:23 ` [PATCH v2 2/4] nvmem: meson-efuse: bindings: Add secure-monitor phandle Carlo Caione
2019-08-06 8:25 ` Jerome Brunet
2019-08-15 21:20 ` Kevin Hilman
2019-08-21 18:14 ` Rob Herring [this message]
2019-08-22 8:36 ` Carlo Caione
2019-08-22 8:59 ` Jerome Brunet
2019-07-31 8:23 ` [PATCH v2 3/4] arm64: dts: meson: Link nvmem and secure-monitor nodes Carlo Caione
2019-08-06 8:26 ` Jerome Brunet
2019-07-31 8:23 ` [PATCH v2 4/4] firmware: meson_sm: Rework driver as a proper platform driver Carlo Caione
2019-08-06 8:23 ` Srinivas Kandagatla
2019-08-05 21:34 ` [PATCH v2 0/4] Rework secure-monitor driver Kevin Hilman
2019-08-06 8:25 ` Srinivas Kandagatla
2019-08-09 21:42 ` Kevin Hilman
2019-09-24 18:45 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821181458.GA2886@bogus \
--to=robh@kernel.org \
--cc=ccaione@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).