From: Mark Brown <broonie@kernel.org>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kuninori.morimoto.gx@renesas.com, lgirdwood@gmail.com,
khilman@baylibre.com, tiwai@suse.com, perex@perex.cz,
linux-amlogic@lists.infradead.org,
Jing Xiangfeng <jingxiangfeng@huawei.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: meson: add the missed kfree() for axg_card_add_tdm_loopback
Date: Thu, 16 Jul 2020 15:34:50 +0100 [thread overview]
Message-ID: <20200716143450.GB5105@sirena.org.uk> (raw)
In-Reply-To: <1jzh7zegfw.fsf@starbuckisacylon.baylibre.com>
[-- Attachment #1.1: Type: text/plain, Size: 539 bytes --]
On Thu, Jul 16, 2020 at 03:29:39PM +0200, Jerome Brunet wrote:
> On Thu 16 Jul 2020 at 15:25, Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:
> > axg_card_add_tdm_loopback() misses to call kfree() in an error path. Add
> > the missed function call to fix it.
> >
> > Fixes: c84836d7f650 ("ASoC: meson: axg-card: use modern dai_link style")
> > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> Thanks for fixing this.
> Maybe it would be better to use the devm_ variant for the name instead ?
Yes, that should be more robust.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-07-16 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 13:25 [PATCH] ASoC: meson: add the missed kfree() for axg_card_add_tdm_loopback Jing Xiangfeng
2020-07-16 13:29 ` Jerome Brunet
2020-07-16 14:34 ` Mark Brown [this message]
2020-07-17 1:49 ` Jing Xiangfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716143450.GB5105@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jbrunet@baylibre.com \
--cc=jingxiangfeng@huawei.com \
--cc=khilman@baylibre.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).