From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Krzysztof Michonski <michonskikrzysztof@gmail.com>
Cc: khilman@baylibre.com, linux-amlogic@lists.infradead.org,
afenkart@gmail.com, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] meson_sm: Extend meson_sm driver to be compatible with gxl chip
Date: Fri, 14 Jun 2019 11:23:35 +0200 [thread overview]
Message-ID: <3421cf72-62ce-cf24-4163-8896660b7b5c@baylibre.com> (raw)
In-Reply-To: <CAFBinCDKPTBwhG-PGFoz25iDq5-DfMT3y3b=k1VJ7MFPnwezFA@mail.gmail.com>
On 07/06/2019 22:27, Martin Blumenstingl wrote:
> Hi Krzysztof,
>
> On Thu, Jun 6, 2019 at 3:24 PM Krzysztof Michonski
> <michonskikrzysztof@gmail.com> wrote:
> [...]
>> +struct meson_sm_chip gxl_chip = {
>> + .shmem_size = SZ_4K,
>> + .cmd_shmem_in_base = 0x82000023,
>> + .cmd_shmem_out_base = 0x82000024,
> where did you get these values from and/or what issues did you see
> with the values from GXBB?
>
> I checked Amlogic's buildroot kernel whether they are doing something similar:
> $ grep in_base_func
> buildroot-openlinux-A113-201901/kernel/aml-4.9/arch/arm64/boot/dts/amlogic/mesong*.dtsi
> | cut -d':' -f2 | sort -u
> in_base_func = <0x82000020>;
> that includes GXL, GXM, G12A and G12B. however, I admit that I didn't
> have time to test your patch yet (so it may be just fine and the
> vendor kernel is buggy)
Same question from me, we've been using the same shmem address on GXL for years now
without any issues, can you elaborate ?
Neil
>
>
> Martin
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-06-14 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 13:24 [PATCH 1/2] meson_sm: Extend meson_sm driver to be compatible with gxl chip Krzysztof Michonski
2019-06-06 13:24 ` [PATCH 2/2] Enable secure monitor on gxl Krzysztof Michonski
2019-06-06 20:02 ` Martin Blumenstingl
[not found] ` <CAOiNxGD2OLwbHhUWuvOV6H0woQEOuk10_t-PTfqvMKNu_tTn4Q@mail.gmail.com>
2019-06-07 20:23 ` Martin Blumenstingl
2019-06-07 20:27 ` [PATCH 1/2] meson_sm: Extend meson_sm driver to be compatible with gxl chip Martin Blumenstingl
2019-06-14 9:23 ` Neil Armstrong [this message]
2019-06-17 8:28 ` Krzysztof Michoński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3421cf72-62ce-cf24-4163-8896660b7b5c@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=afenkart@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=michonskikrzysztof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).