From: Neil Armstrong <narmstrong@baylibre.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: jernej.skrabec@siol.net, jonas@kwiboo.se,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
a.hajda@samsung.com, boris.brezillon@collabora.com,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v3 02/10] drm/bridge: dw-hdmi: add max bpc connector property
Date: Thu, 19 Dec 2019 09:52:31 +0100 [thread overview]
Message-ID: <401ecf72-fca2-28bc-9b72-b3e63b380865@baylibre.com> (raw)
In-Reply-To: <20191218154942.GG4863@pendragon.ideasonboard.com>
On 18/12/2019 16:49, Laurent Pinchart wrote:
> Hi Neil and Jonas,
>
> Thank you for the patch.
>
> On Wed, Dec 18, 2019 at 04:46:29PM +0100, Neil Armstrong wrote:
>> From: Jonas Karlman <jonas@kwiboo.se>
>>
>> Add the max_bpc property to the dw-hdmi connector to prepare support
>> for 10, 12 & 16bit output support.
>>
>> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> index 6a0b4b3a6739..e7a0600f8cc5 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
>> @@ -2368,6 +2368,10 @@ static int dw_hdmi_bridge_attach(struct drm_bridge *bridge)
>> DRM_MODE_CONNECTOR_HDMIA,
>> hdmi->ddc);
>>
>> + drm_atomic_helper_connector_reset(connector);
>> +
>> + drm_connector_attach_max_bpc_property(connector, 8, 16);
>> +
>
> I'm not asking you to rework this, but have you given any thought on how
> we would be able to support this feature in a model where the bridge
> wouldn't create a connector anymore (as done in the latest version of
> the omapdrm series) ?
Not yet, but the plan is to have this serie merged (it's on the list for more than 1y now),
then we'll switch to a separate connector.
>
>> if (hdmi->version >= 0x200a && hdmi->plat_data->use_drm_infoframe)
>> drm_object_attach_property(&connector->base,
>> connector->dev->mode_config.hdr_output_metadata_property, 0);
>
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-12-19 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 15:46 [PATCH v3 00/10] drm/bridge: dw-hdmi: implement bus-format negotiation and YUV420 support Neil Armstrong
2019-12-18 15:46 ` [PATCH v3 01/10] drm/bridge: dw-hdmi: set mtmdsclock for deep color Neil Armstrong
2019-12-18 15:46 ` [PATCH v3 02/10] drm/bridge: dw-hdmi: add max bpc connector property Neil Armstrong
2019-12-18 15:49 ` Laurent Pinchart
2019-12-19 8:52 ` Neil Armstrong [this message]
2019-12-18 15:46 ` [PATCH v3 03/10] drm/bridge: synopsys: dw-hdmi: add bus format negociation Neil Armstrong
2019-12-18 15:46 ` [PATCH v3 04/10] drm/bridge: synopsys: dw-hdmi: allow ycbcr420 modes for >= 0x200a Neil Armstrong
2019-12-18 15:46 ` [PATCH v3 05/10] drm/meson: venc: make drm_display_mode const Neil Armstrong
2019-12-18 15:46 ` [PATCH v3 06/10] drm/meson: meson_dw_hdmi: add bridge and switch to drm_bridge_funcs Neil Armstrong
2019-12-18 15:46 ` [PATCH v3 07/10] drm/meson: dw-hdmi: stop enforcing input_bus_format Neil Armstrong
2019-12-18 15:46 ` [PATCH v3 08/10] drm/meson: venc: add support for YUV420 setup Neil Armstrong
2019-12-18 15:46 ` [PATCH v3 09/10] drm/meson: vclk: " Neil Armstrong
2019-12-18 15:46 ` [PATCH v3 10/10] drm/meson: Add YUV420 output support Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=401ecf72-fca2-28bc-9b72-b3e63b380865@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=a.hajda@samsung.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).