From: Neil Armstrong <narmstrong@baylibre.com>
To: Andrew Murray <andrew.murray@arm.com>
Cc: devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com,
khilman@baylibre.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, kishon@ti.com, repk@triplefau.lt,
maz@kernel.org, bhelgaas@google.com,
linux-amlogic@lists.infradead.org, yue.wang@Amlogic.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] dt-bindings: pci: amlogic,meson-pcie: Add G12A bindings
Date: Wed, 11 Sep 2019 14:30:43 +0200 [thread overview]
Message-ID: <62994535-1617-9f71-4059-b8c4da8ecbd1@baylibre.com> (raw)
In-Reply-To: <20190911122250.GT9720@e119886-lin.cambridge.arm.com>
Hi Andrew,
On 11/09/2019 14:22, Andrew Murray wrote:
> On Sun, Sep 08, 2019 at 01:42:53PM +0000, Neil Armstrong wrote:
>> Add PCIE bindings for the Amlogic G12A SoC, the support is the same
>> but the PHY is shared with USB3 to control the differential lines.
>>
>> Thus this adds a phy phandle to control the PHY, and sets invalid
>> MIPI clock as optional for G12A.
>
> Perhaps reword to "Thus this adds a phy phandle to control the PHY,
> and only requires a MIPI clock for AXG SoC Family".
Sure, thanks,
Neil
>
> Thanks,
>
> Andrew Murray
>
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> .../devicetree/bindings/pci/amlogic,meson-pcie.txt | 12 ++++++++----
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/amlogic,meson-pcie.txt b/Documentation/devicetree/bindings/pci/amlogic,meson-pcie.txt
>> index efa2c8b9b85a..84fdc422792e 100644
>> --- a/Documentation/devicetree/bindings/pci/amlogic,meson-pcie.txt
>> +++ b/Documentation/devicetree/bindings/pci/amlogic,meson-pcie.txt
>> @@ -9,13 +9,16 @@ Additional properties are described here:
>>
>> Required properties:
>> - compatible:
>> - should contain "amlogic,axg-pcie" to identify the core.
>> + should contain :
>> + - "amlogic,axg-pcie" for AXG SoC Family
>> + - "amlogic,g12a-pcie" for G12A SoC Family
>> + to identify the core.
>> - reg:
>> should contain the configuration address space.
>> - reg-names: Must be
>> - "elbi" External local bus interface registers
>> - "cfg" Meson specific registers
>> - - "phy" Meson PCIE PHY registers
>> + - "phy" Meson PCIE PHY registers for AXG SoC Family
>> - "config" PCIe configuration space
>> - reset-gpios: The GPIO to generate PCIe PERST# assert and deassert signal.
>> - clocks: Must contain an entry for each entry in clock-names.
>> @@ -23,12 +26,13 @@ Required properties:
>> - "pclk" PCIe GEN 100M PLL clock
>> - "port" PCIe_x(A or B) RC clock gate
>> - "general" PCIe Phy clock
>> - - "mipi" PCIe_x(A or B) 100M ref clock gate
>> + - "mipi" PCIe_x(A or B) 100M ref clock gate for AXG SoC Family
>> - resets: phandle to the reset lines.
>> - reset-names: must contain "phy" "port" and "apb"
>> - - "phy" Share PHY reset
>> + - "phy" Share PHY reset for AXG SoC Family
>> - "port" Port A or B reset
>> - "apb" Share APB reset
>> +- phys: should contain a phandle to the shared phy for G12A SoC Family
>> - device_type:
>> should be "pci". As specified in designware-pcie.txt
>>
>> --
>> 2.17.1
>>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-09-11 12:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 13:42 [PATCH 0/6] arm64: dts: meson-g12: add support for PCIe Neil Armstrong
2019-09-08 13:42 ` [PATCH 1/6] dt-bindings: pci: amlogic,meson-pcie: Add G12A bindings Neil Armstrong
2019-09-11 12:22 ` Andrew Murray
2019-09-11 12:30 ` Neil Armstrong [this message]
2019-09-13 14:36 ` [PATCH 1/6] dt-bindings: pci: amlogic, meson-pcie: " Rob Herring
2019-09-08 13:42 ` [PATCH 2/6] PCI: amlogic: Fix probed clock names Neil Armstrong
2019-09-11 10:59 ` Andrew Murray
2019-09-08 13:42 ` [PATCH 3/6] PCI: amlogic: meson: Add support for G12A Neil Armstrong
2019-09-11 11:36 ` Andrew Murray
2019-09-11 12:39 ` Neil Armstrong
2019-09-11 12:58 ` Andrew Murray
2019-09-08 13:42 ` [PATCH 4/6] phy: meson-g12a-usb3-pcie: Add support for PCIe mode Neil Armstrong
2019-09-11 12:19 ` Andrew Murray
2019-09-11 12:45 ` Neil Armstrong
2019-09-11 12:59 ` Andrew Murray
2019-09-08 13:42 ` [PATCH 5/6] arm64: dts: meson-g12a: Add PCIe node Neil Armstrong
2019-09-08 13:42 ` [PATCH 6/6] arm64: dts: khadas-vim3: add commented support for PCIe Neil Armstrong
2019-09-09 16:37 ` Marc Zyngier
2019-09-09 17:50 ` Neil Armstrong
2019-09-10 9:12 ` Marc Zyngier
2019-09-10 9:14 ` Neil Armstrong
2019-09-11 12:50 ` Andrew Murray
2019-09-11 12:58 ` Neil Armstrong
2019-09-11 13:11 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62994535-1617-9f71-4059-b8c4da8ecbd1@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=andrew.murray@arm.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=maz@kernel.org \
--cc=repk@triplefau.lt \
--cc=yue.wang@Amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).