From: Xingyu Chen <xingyu.chen@amlogic.com>
To: Julius Werner <jwerner@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Evan Benn <evanbenn@chromium.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Yonghui Yu <yonghui.yu@amlogic.com>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
"David S. Miller" <davem@davemloft.net>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible
Date: Sat, 14 Mar 2020 00:13:01 +0800 [thread overview]
Message-ID: <6e846246-dfd5-c002-cd61-41c2d11a2e54@amlogic.com> (raw)
In-Reply-To: <CAODwPW9oxx33hkO3kv2_G8YyLWvigVHkfJU7xUHLVgB7QU2i3Q@mail.gmail.com>
Hi, Julius
On 2020/3/12 3:24, Julius Werner wrote:
>> - *_INIT and *GETTIMEOUT. Although your driver does not need them, could you take them as options in your driver ?
> The driver already has SMCWD_INFO which is used during probe to
> retrieve the minimum and maximum timeout values supported by the
> hardware at probe time. Maybe it would make sense to rename that to
> INIT (which would still return those values, but can also do whatever
> initialization needs to be done in TF)?
Yes，INIT would make sense for me.
> GETTIMELEFT I agree we can
> implement optionally, and other platforms would just return a
> PSCI_RET_NOT_SUPPORTED for that.
>
>> - *_RESETNOW. It is used to reset the system right now, similar to your SOFT RESET. could you reserve an operation index in ATF ?
> Just curious, why do you need this? Shouldn't you use the PSCI
> standard SYSTEM_RESET SMC for that? (If you want to control exactly
> how the platform is reset, you could also use SYSTEM_RESET2 with a
> vendor-defined reset_type.)
I just wanted it to be compatible with other OS，and I think it over,
maybe I can also use the
PSCI interface to execuate the system reset on the other OS. Anyway,
please ignore this request.
Thanks.
>
> .
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2020-03-13 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200214062637.216209-1-evanbenn@chromium.org>
[not found] ` <20200214172512.1.I02ebc5b8743b1a71e0e15f68ea77e506d4e6f840@changeid>
[not found] ` <20200219223046.GA16537@bogus>
[not found] ` <CAODwPW8JspiUtyU4CC95w9rbNRyUF-Aeb9TuPm1PzmP6u=y1EA@mail.gmail.com>
[not found] ` <20200219232005.GA9737@roeck-us.net>
[not found] ` <CAKz_xw2hvHL=a4s37dmuCTWDbxefQFR3rfcaNiWYJY4T+jqabA@mail.gmail.com>
[not found] ` <e42320b8-266f-0b0e-b20b-b72228510e81@amlogic.com>
[not found] ` <CAODwPW94KX46PzSrf_uuEFPKudXor=26d=g3Qta5veRfxmMDUA@mail.gmail.com>
[not found] ` <1326f594-3cfd-c03d-4f2c-50eeb75724b2@amlogic.com>
[not found] ` <CAODwPW8WwntWb_=dg2J3AMy-gHw2QvNj_g98SufN13+AuGnUSg@mail.gmail.com>
2020-02-25 7:44 ` [PATCH 1/2] dt-bindings: watchdog: Add arm,smc-wdt watchdog arm,smc-wdt compatible Xingyu Chen
2020-03-10 1:00 ` Evan Benn
[not found] ` <ad28aa47-0490-937f-898f-0e4695ef6ec6@amlogic.com>
2020-03-11 19:24 ` Julius Werner
2020-03-13 16:13 ` Xingyu Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e846246-dfd5-c002-cd61-41c2d11a2e54@amlogic.com \
--to=xingyu.chen@amlogic.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=evanbenn@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jianxin.pan@amlogic.com \
--cc=jwerner@chromium.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=yonghui.yu@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).