From: Neil Armstrong <narmstrong@baylibre.com>
To: balbi@kernel.org, khilman@baylibre.com
Cc: linux-amlogic@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/3] usb: dwc3: parkmode_disable_ss_quirk on DWC3 controller
Date: Fri, 21 Feb 2020 10:11:34 +0100 [thread overview]
Message-ID: <72443f63-d2fa-8eb5-ef56-98844bc59d55@baylibre.com> (raw)
In-Reply-To: <20200219141817.24521-1-narmstrong@baylibre.com>
On 19/02/2020 15:18, Neil Armstrong wrote:
> In certain circumstances, the XHCI SuperSpeed instance in park mode
> can fail to recover, thus on Amlogic G12A/G12B/SM1 SoCs when there is high
> load on the single XHCI SuperSpeed instance, the controller can crash like:
> xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
> xhci-hcd xhci-hcd.0.auto: Host halt failed, -110
> xhci-hcd xhci-hcd.0.auto: xHCI host controller not responding, assume dead
> xhci-hcd xhci-hcd.0.auto: xHCI host not responding to stop endpoint command.
> hub 2-1.1:1.0: hub_ext_port_status failed (err = -22)
> xhci-hcd xhci-hcd.0.auto: HC died; cleaning up
> usb 2-1.1-port1: cannot reset (err = -22)
>
> Setting the PARKMODE_DISABLE_SS bit in the DWC3_USB3_GUCTL1 mitigates
> the issue. The bit is described as :
> "When this bit is set to '1' all SS bus instances in park mode are disabled"
>
> The bug has been reproduced by Jun Li <lijun.kernel@gmail.com> and confirmed
> by Thinh Nguyen <Thinh.Nguyen@synopsys.com> with the explanation:
>> The GUCTL1.PARKMODE_DISABLE_SS is only available in dwc_usb3 controller
>> running in host mode. This should not be set for other IPs.
>> This can be disabled by default based on IP, but I recommend to have a
>> property to enable this feature for devices that need this.
>
> Changes since v2 at [2]:
> - rebased on v5.6-rc2
>
> Changes since v1 at [1]:
> - added rob review tag
> - added Thinh Nguyen in commit log
>
> [1] https://lore.kernel.org/linux-amlogic/20191014141718.22603-1-narmstrong@baylibre.com
> [1] https://lore.kernel.org/linux-amlogic/20200109101535.26812-1-narmstrong@baylibre.com
>
> Neil Armstrong (3):
> doc: dt: bindings: usb: dwc3: Update entries for disabling SS
> instances in park mode
> usb: dwc3: gadget: Add support for disabling SS instances in park mode
> arm64: dts: g12-common: add parkmode_disable_ss_quirk on DWC3
> controller
>
> Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 1 +
> drivers/usb/dwc3/core.c | 5 +++++
> drivers/usb/dwc3/core.h | 4 ++++
> 4 files changed, 12 insertions(+)
>
Please ignore this serie, the patch 3 subject is wrong.
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2020-02-21 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 14:18 [PATCH v3 0/3] usb: dwc3: parkmode_disable_ss_quirk on DWC3 controller Neil Armstrong
2020-02-19 14:18 ` [PATCH v3 1/3] doc: dt: bindings: usb: dwc3: Update entries for disabling SS instances in park mode Neil Armstrong
2020-02-19 14:18 ` [PATCH v3 2/3] usb: dwc3: gadget: Add support " Neil Armstrong
2020-02-21 1:59 ` Jun Li
2020-02-21 9:10 ` Neil Armstrong
2020-02-19 14:18 ` [PATCH v3 3/3] arm64: dts: g12-common: add parkmode_disable_ss_quirk on DWC3 controller Neil Armstrong
2020-02-21 9:11 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72443f63-d2fa-8eb5-ef56-98844bc59d55@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=balbi@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).