From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/3] ARM: dts: meson: add the APB/APB2 busses
Date: Thu, 10 Jan 2019 16:36:27 -0800 [thread overview]
Message-ID: <7himywqbck.fsf@baylibre.com> (raw)
In-Reply-To: <ba3e4fef-7a18-8c7d-e0ea-05c541b29913@baylibre.com>
Neil Armstrong <narmstrong@baylibre.com> writes:
> On 08/12/2018 17:50, Martin Blumenstingl wrote:
>> This adds the APB bus on Meson8 and Meson8b as well as the APB2 bus on
>> Meson6. This is preparation work for adding the Mali GPU which is
>> located on theses busses.
>>
>> Meson6 seems to have it's APB at 0xc8000000 instead of 0xd0000000. The
>> region at 0xd0000000 is called APB2 or A9_APB and it has a different
>> size (256k) compared to Meson8 and Meson8b (2M).
>>
>> Addresses and sizes are taken from the Amlogic 3.10 kernel sources:
>> - Meson6: [0]
>> - Meson8: [1]
>> - Meson8b: [2]
>>
>>
>> Changes since v1 at [3]:
>> - re-send the patches but this time don't include the old patches
>> which still had a typo in the patch description (ABP vs APB)
>>
>>
>> [0] https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson6/include/mach/io.h#L61
>> [1] https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson8/include/mach/io.h#L53
>> [2] https://github.com/endlessm/linux-meson/blob/cd4096c3ff4eb5b8a8a5581bb46508601c5470dc/arch/arm/mach-meson8b/include/mach/io.h#L53
>> [3] http://lists.infradead.org/pipermail/linux-amlogic/2018-December/009424.html
>>
>>
>> Martin Blumenstingl (3):
>> ARM: dts: meson6: add the APB2 bus
>> ARM: dts: meson8: add the APB bus
>> ARM: dts: meson8b: add the APB bus
>>
>> arch/arm/boot/dts/meson6.dtsi | 8 ++++++++
>> arch/arm/boot/dts/meson8.dtsi | 8 ++++++++
>> arch/arm/boot/dts/meson8b.dtsi | 8 ++++++++
>> 3 files changed, 24 insertions(+)
>>
>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
> But frankly I'll squash the meson8/meson8b patches with the mali node patches !
In general, I agree with Neil. Adding the new busses along with the
series that uses them would be fine, but I don't have a strong
preference.
So queueing this series as is for v5.1 (branch: v5.1/dt)
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2019-01-11 0:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 16:50 [PATCH v2 0/3] ARM: dts: meson: add the APB/APB2 busses Martin Blumenstingl
2018-12-08 16:50 ` [PATCH v2 1/3] ARM: dts: meson6: add the APB2 bus Martin Blumenstingl
2018-12-08 16:50 ` [PATCH v2 2/3] ARM: dts: meson8: add the APB bus Martin Blumenstingl
2018-12-08 16:50 ` [PATCH v2 3/3] ARM: dts: meson8b: " Martin Blumenstingl
2018-12-11 9:16 ` [PATCH v2 0/3] ARM: dts: meson: add the APB/APB2 busses Neil Armstrong
2018-12-11 22:09 ` Martin Blumenstingl
2018-12-12 9:52 ` Neil Armstrong
2019-01-11 0:36 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7himywqbck.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).