From: "Tan, Ley Foon" <ley.foon.tan@intel.com>
To: "Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Binghui Wang <wangbinghui@hisilicon.com>,
"linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Toan Le <toan@os.amperecomputing.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Pratyush Anand <pratyush.anand@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
Kukjin Kim <kgene@kernel.org>,
Xiaowei Song <songxiaowei@hisilicon.com>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Linus Walleij <linus.walleij@linaro.org>,
Richard Zhu <hongxing.zhu@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Yue Wang <yue.wang@Amlogic.com>,
Murali Karicheri <m-karicheri2@ti.com>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-amlogic@lists.infradead.org"
<linux-amlogic@lists.infradead.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Jingoo Han <jingoohan1@gmail.com>,
"rfi@lists.rocketboards.org" <rfi@lists.rocketboards.org>,
Shawn Guo <shawnguo@kernel.org>,
Lucas Stach <l.stach@pengutronix.de>
Subject: RE: [PATCH 04/10] PCI: altera: Remove dev_err() when handing an error from platform_get_irq()
Date: Mon, 3 Aug 2020 06:19:02 +0000 [thread overview]
Message-ID: <BY5PR11MB38934F2DF0BA55EBF2965B34CC4D0@BY5PR11MB3893.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200802142601.1635926-5-kw@linux.com>
> -----Original Message-----
> From: Krzysztof Wilczyński <kw@linux.com>
> Sent: Sunday, August 2, 2020 10:26 PM
> To: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jingoo Han <jingoohan1@gmail.com>; Kukjin Kim <kgene@kernel.org>;
> Krzysztof Kozlowski <krzk@kernel.org>; Richard Zhu
> <hongxing.zhu@nxp.com>; Lucas Stach <l.stach@pengutronix.de>; Shawn
> Guo <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>;
> Murali Karicheri <m-karicheri2@ti.com>; Yue Wang
> <yue.wang@Amlogic.com>; Kevin Hilman <khilman@baylibre.com>; Thomas
> Petazzoni <thomas.petazzoni@bootlin.com>; Jesper Nilsson
> <jesper.nilsson@axis.com>; Xiaowei Song <songxiaowei@hisilicon.com>;
> Binghui Wang <wangbinghui@hisilicon.com>; Pratyush Anand
> <pratyush.anand@gmail.com>; Hou Zhiqiang <Zhiqiang.Hou@nxp.com>;
> Linus Walleij <linus.walleij@linaro.org>; Toan Le
> <toan@os.amperecomputing.com>; Tan, Ley Foon
> <ley.foon.tan@intel.com>; Shawn Lin <shawn.lin@rock-chips.com>; Heiko
> Stuebner <heiko@sntech.de>; linux-amlogic@lists.infradead.org; linux-arm-
> kernel@axis.com; linux-arm-kernel@lists.infradead.org; linux-
> omap@vger.kernel.org; linux-pci@vger.kernel.org; linux-
> rockchip@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> tegra@vger.kernel.org; rfi@lists.rocketboards.org
> Subject: [PATCH 04/10] PCI: altera: Remove dev_err() when handing an error
> from platform_get_irq()
>
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from either the platform_get_irq() or
> platform_get_irq_byname() functions as both are going to display an
> appropriate error message in case of a failure.
>
> This change is as per suggestion from Coccinelle:
>
> drivers/pci/controller/pcie-altera.c:717:2-9: line 717 is redundant
> because platform_get_irq() already prints an error
>
> Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
> ---
Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-08-03 6:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 14:25 [PATCH 00/10] Remove surplus dev_err() when handing an error from platform_get_irq() Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 01/10] PCI: dwc: Remove " Krzysztof Wilczyński
2020-08-03 7:16 ` Jesper Nilsson
2020-08-02 14:25 ` [PATCH 02/10] PCI: mobiveil: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 03/10] PCI: tegra: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 04/10] PCI: altera: " Krzysztof Wilczyński
2020-08-03 6:19 ` Tan, Ley Foon [this message]
2020-08-02 14:25 ` [PATCH 05/10] PCI: host-generic: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 06/10] PCI: v3-semi: " Krzysztof Wilczyński
2020-08-02 14:25 ` [PATCH 07/10] PCI: altera-msi: " Krzysztof Wilczyński
2020-08-02 14:26 ` [PATCH 08/10] PCI: xgene-msi: " Krzysztof Wilczyński
2020-08-02 14:26 ` [PATCH 09/10] PCI: rockchip: " Krzysztof Wilczyński
2020-08-03 2:01 ` [PATCH 00/10] Remove surplus " Bjorn Helgaas
2020-08-03 11:10 ` Krzysztof Wilczyński
2020-08-03 14:55 ` Bjorn Helgaas
2020-08-03 7:10 ` [PATCH 10/10] PCI: xilinx-nwl: Remove " Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB38934F2DF0BA55EBF2965B34CC4D0@BY5PR11MB3893.namprd11.prod.outlook.com \
--to=ley.foon.tan@intel.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bhelgaas@google.com \
--cc=heiko@sntech.de \
--cc=hongxing.zhu@nxp.com \
--cc=jesper.nilsson@axis.com \
--cc=jingoohan1@gmail.com \
--cc=kgene@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=pratyush.anand@gmail.com \
--cc=rfi@lists.rocketboards.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.lin@rock-chips.com \
--cc=shawnguo@kernel.org \
--cc=songxiaowei@hisilicon.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=toan@os.amperecomputing.com \
--cc=wangbinghui@hisilicon.com \
--cc=yue.wang@Amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).