From: Rob Herring <robh+dt@kernel.org>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
baylibre-upstreaming@groups.io,
Kevin Hilman <khilman@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
linux-amlogic@lists.infradead.org,
David Miller <davem@davemloft.net>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/4] dt-bindings: crypto: Add DT bindings documentation for amlogic-crypto
Date: Thu, 25 Jul 2019 16:55:30 -0600 [thread overview]
Message-ID: <CAL_JsqLbYwRpNWHGkYbomWLMpum_DXW4OjNNRrwTRM=w86dONw@mail.gmail.com> (raw)
In-Reply-To: <1564083776-20540-2-git-send-email-clabbe@baylibre.com>
On Thu, Jul 25, 2019 at 1:43 PM Corentin Labbe <clabbe@baylibre.com> wrote:
>
> This patch adds documentation for Device-Tree bindings for the
> Amlogic GXL cryptographic offloader driver.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> .../bindings/crypto/amlogic-gxl-crypto.yaml | 45 +++++++++++++++++++
Follow the compatible string for the filename: amlogic,gxl-crypto.yaml
> 1 file changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/crypto/amlogic-gxl-crypto.yaml
>
> diff --git a/Documentation/devicetree/bindings/crypto/amlogic-gxl-crypto.yaml b/Documentation/devicetree/bindings/crypto/amlogic-gxl-crypto.yaml
> new file mode 100644
> index 000000000000..41265e57c00b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/amlogic-gxl-crypto.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: GPL-2.0
Dual (GPL-2.0 OR BSD-2-Clause) is preferred for new bindings. Not a
requirement though.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/amlogic-gxl-crypto.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Amlogic GXL Cryptographic Offloader
> +
> +maintainers:
> + - Corentin Labbe <clabbe@baylibre.com>
> +
> +properties:
> + compatible:
> + oneOf:
Don't need 'oneOf' when there is only 1.
> + - const: amlogic,gxl-crypto
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: blkmv
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +examples:
> + - |
> + crypto: crypto@c883e000 {
> + compatible = "amlogic,gxl-crypto";
> + reg = <0x0 0xc883e000 0x0 0x36>;
This should throw errors because the default size on examples are 1
cell. But validating the examples with the schema only just landed in
5.3-rc1.
> + interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 189 IRQ_TYPE_EDGE_RISING>;
This doesn't match the schema.
> + clocks = <&clkc CLKID_BLKMV>;
> + clock-names = "blkmv";
> + };
> --
> 2.21.0
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-07-25 22:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 19:42 [PATCH 0/4] crypto: add amlogic crypto offloader driver Corentin Labbe
2019-07-25 19:42 ` [PATCH 1/4] dt-bindings: crypto: Add DT bindings documentation for amlogic-crypto Corentin Labbe
2019-07-25 22:55 ` Rob Herring [this message]
2019-07-26 11:07 ` LABBE Corentin
[not found] ` <15B4F061F360B2F0.8182@groups.io>
2019-07-26 12:54 ` LABBE Corentin
2019-07-25 19:42 ` [PATCH 2/4] crypto: amlogic: Add crypto accelerator for amlogic GXL Corentin Labbe
2019-07-27 12:17 ` Martin Blumenstingl
2019-08-01 12:46 ` LABBE Corentin
2019-07-25 19:42 ` [PATCH 3/4] MAINTAINERS: Add myself as maintainer of amlogic crypto Corentin Labbe
2019-07-25 19:42 ` [PATCH 4/4] ARM64: dts: amlogic: adds crypto hardware node Corentin Labbe
2019-07-28 18:48 ` [PATCH 0/4] crypto: add amlogic crypto offloader driver Eric Biggers
2019-07-28 19:42 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLbYwRpNWHGkYbomWLMpum_DXW4OjNNRrwTRM=w86dONw@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=baylibre-upstreaming@groups.io \
--cc=clabbe@baylibre.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).