From: Finn Thain <fthain@telegraphics.com.au>
To: Tom Rix <trix@redhat.com>
Cc: alsa-devel@alsa-project.org, linux-aspeed@lists.ozlabs.org,
linux-iio@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-rdma@vger.kernel.org,
qat-linux@intel.com, amd-gfx@lists.freedesktop.org,
clang-built-linux@googlegroups.com, linux-pm@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
tipc-discussion@lists.sourceforge.net,
linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [RFC] clang tooling cleanups
Date: Wed, 28 Oct 2020 14:26:12 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LNX.2.23.453.2010281344120.31@nippy.intranet> (raw)
In-Reply-To: <20201027164255.1573301-1-trix@redhat.com>
On Tue, 27 Oct 2020, trix@redhat.com wrote:
> This rfc will describe
> An upcoming treewide cleanup.
> How clang tooling was used to programatically do the clean up.
> Solicit opinions on how to generally use clang tooling.
>
This tooling is very impressive. It makes possible an idea that I had a
while ago, to help make code review more efficient. It works like this.
Suppose a patch, p, is the difference between the new tree, n, and the old
tree, o. That is, p = n - o.
Now let clang-tidy be the transformation 't'. This gets you a much more
readable patch submission, P = t(n) - t(o).
The only difficulty is that, if I submit P intead of p then 'git am' will
probably reject it. This is solved by a little tooling around git, such
that, should a patch P fail to apply, the relevant files are automatically
reformatted with the officially endorsed transformation t, to generate a
minimal cleanup patch, such that P can be automatically applied on top.
If the patch submission process required* that every patch submission was
generated like P and not like p, it would immediately eliminate all
clean-up patches from the workload of all reviewers, and also make the
reviewers' job easier because all submissions are now formatted correctly,
and also avoid time lost to round-trips, such as, "you can have a
reviewed-by if you respin to fix some minor style issues".
* Enforcing this, e.g. with checkpatch, is slightly more complicated, but
it works the same way: generate a minimal cleanup patch for the relevant
files, apply the patch-to-be-submitted, and finally confirm that the
modified files are unchanged under t.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-10-28 3:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 16:42 Subject: [RFC] clang tooling cleanups trix
2020-10-28 3:26 ` Finn Thain [this message]
2020-11-10 2:52 ` Joe Perches
2020-11-10 13:12 ` Tom Rix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.23.453.2010281344120.31@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=alsa-devel@alsa-project.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=clang-built-linux@googlegroups.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qat-linux@intel.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).