linux-amlogic.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Tim <elatllat@gmail.com>,
	"open list:ARM/Amlogic Meson..."
	<linux-amlogic@lists.infradead.org>,
	tobetter@gmail.com, Jianxin Pan <jianxin.pan@amlogic.com>
Subject: Re: meson-g12b xHCI - disable park mode
Date: Thu, 26 Sep 2019 14:53:29 +0200	[thread overview]
Message-ID: <c39e0cd2-1235-c574-c90a-a17727a76b05@baylibre.com> (raw)
In-Reply-To: <CA+3zgmvjhisn97Y1TCn7Ztj2m3hB9+sdoOnFdvJJbKUFpt=QrQ@mail.gmail.com>

Hi Tim,

Thanks for sending the email, this has already been spotted by Christian Hewitt from LibreELEC.

Indeed this need some dt-bindings work and some more information for these :
- DWC3_GUCTL_NAKPERENHHS
- DWC3_GUCTL_PARKMODEDISABLESS
bit from Amlogic since I don't access to the DWC3 DataBook.

Jianxin, could you give use a brief description of these bits and why they are needed to solve the issue ?

Thanks,
Neil

On 21/09/2019 15:47, Tim wrote:
> Hi Neil,
> 
> Thank you for your work on the Linux kernel.
> Hardkernel and others using the mainline on the N2 are including a patch[1] that prevents bugs[2] on the Odroid-N2. 
> Dongjin Kim <tobetter@gmail.com <mailto:tobetter@gmail.com>> obtained the patch from AmLogic[3],
> but is not comfortable contributing to upstream[4].
> Please fix this bug upstream, or let us know the best way forward.
> (maybe you can send something appropriate for Felipe to review)
> Thanks again.
> 
> Reference links;
> 
>     1 https://forum.odroid.com/download/file.php?id=9674
>     2 https://forum.odroid.com/viewtopic.php?f=181&t=35031&start=250#p267479
>     3 https://forum.odroid.com/viewtopic.php?f=181&t=35031&start=250#p267481
>     4 https://forum.odroid.com/viewtopic.php?f=176&t=33993&start=350#p268598
> 
> 
> The patch inline;
> 
>     diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>     index c9bb93a2c..8252923d8 100644
>     --- a/drivers/usb/dwc3/core.c
>     +++ b/drivers/usb/dwc3/core.c
>     @@ -983,6 +983,8 @@ static int dwc3_core_init(struct dwc3 *dwc)
>       if (dwc->dis_tx_ipgap_linecheck_quirk)
>       reg |= DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS;
>      
>     + reg |= (DWC3_GUCTL_NAKPERENHHS | DWC3_GUCTL_PARKMODEDISABLESS);
>     +
>       dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
>       }
>      
>     diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>     index 3dd783b88..ff09d19ee 100644
>     --- a/drivers/usb/dwc3/core.h
>     +++ b/drivers/usb/dwc3/core.h
>     @@ -247,6 +247,8 @@
>      
>      /* Global User Control Register */
>      #define DWC3_GUCTL_HSTINAUTORETRY BIT(14)
>     +#define DWC3_GUCTL_PARKMODEDISABLESS   BIT(17)
>     +#define DWC3_GUCTL_NAKPERENHHS         BIT(18)
>      
>      /* Global User Control 1 Register */
>      #define DWC3_GUCTL1_TX_IPGAP_LINECHECK_DIS BIT(28)
> 
> <https://forum.odroid.com/viewtopic.php?f=176&t=33993&start=350#p268598>


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

       reply	other threads:[~2019-09-26 12:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CA+3zgmvjhisn97Y1TCn7Ztj2m3hB9+sdoOnFdvJJbKUFpt=QrQ@mail.gmail.com>
2019-09-26 12:53 ` Neil Armstrong [this message]
     [not found]   ` <2019092715010469964015@amlogic.com>
2019-09-27 11:34     ` meson-g12b xHCI - disable park mode Neil Armstrong
2019-09-27 13:25       ` [PATCH] dwc3: add parkmode_disable_ss_quirk for G12A Neil Armstrong
     [not found]         ` <CA+3zgmvmXwrXjM_xPZuumUhOEjqFqv7WofXGLDvY0S5JedN4Wg@mail.gmail.com>
2019-09-29  1:36           ` Fwd: " Tim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c39e0cd2-1235-c574-c90a-a17727a76b05@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=elatllat@gmail.com \
    --cc=jianxin.pan@amlogic.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=tobetter@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).