From: Hanjie Lin <hanjie.lin@amlogic.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Rob Herring <robh@kernel.org>,
Victor Wan <victor.wan@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-usb@vger.kernel.org, Yue Wang <yue.wang@amlogic.com>,
devicetree@vger.kernel.org, Qiufang Dai <qiufang.dai@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>,
linux-arm-kernel@lists.infradead.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Carlo Caione <carlo@caione.org>,
linux-amlogic@lists.infradead.org,
Liang Yang <liang.yang@amlogic.com>,
Xingyu Chen <xingyu.chen@amlogic.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH v3 4/6] usb: dwc3: Add Amlogic A1 DWC3 glue
Date: Thu, 2 Jan 2020 08:30:43 +0800 [thread overview]
Message-ID: <d66abc21-1440-503b-3515-6c495bf0db80@amlogic.com> (raw)
In-Reply-To: <CAFBinCD8V-Swihz+VJ780sXJtM9cXprDcGCHVuHjjCx0DEOodQ@mail.gmail.com>
On 2019/12/28 0:38, Martin Blumenstingl wrote:
> Hello Hanjie,
>
> sorry that it took me so long to look at this
> you can find my comments below
>
> On Fri, Dec 27, 2019 at 7:37 AM Hanjie Lin <hanjie.lin@amlogic.com> wrote:
> [...]
>> +static const struct clk_bulk_data meson_g12a_clocks[] = {
>> + { .id = NULL},
>> +};
>> +
>> +static const struct clk_bulk_data meson_a1_clocks[] = {
>> + { .id = "usb_ctrl"},
>> + { .id = "usb_bus"},
>> + { .id = "xtal_usb_phy"},
>> + { .id = "xtal_usb_ctrl"},
>> +};
> nit-pick: the values in meson_g12a_clocks and meson_a1_clocks all have
> a space after the opening "{" but no space before the closing "}"
> we should be consistent here (personally I prefer the variant with
> space after "{" and before "}", but having no space in both cases is
> fine for me too)
>
Right, I will fix it.
> [...]
>> static void dwc3_meson_g12a_usb2_set_mode(struct dwc3_meson_g12a *priv,
>> @@ -138,10 +156,13 @@ static int dwc3_meson_g12a_usb2_init(struct dwc3_meson_g12a *priv)
>> {
>> int i;
>>
>> - if (priv->otg_mode == USB_DR_MODE_PERIPHERAL)
>> - priv->otg_phy_mode = PHY_MODE_USB_DEVICE;
>> - else
>> - priv->otg_phy_mode = PHY_MODE_USB_HOST;
>> + /* only G12A supports otg mode */
>> + if (priv->soc_id == MESON_SOC_G12A) {
>> + if (priv->otg_mode == USB_DR_MODE_PERIPHERAL)
>> + priv->otg_phy_mode = PHY_MODE_USB_DEVICE;
>> + else
>> + priv->otg_phy_mode = PHY_MODE_USB_HOST;
>> + }
> can you comment on future Amlogic SoCs and how this code will look in
> the future?
> I would like to avoid having to adjust this "if" for every new SoC,
> but I don't know if the majority of the SoCs will have OTG support
>
> also one idea that just came to my mind:
> you could define in the .yaml binding that for A1 only dr_mode =
> "host" is allowed
> then you may not need extra logic in the driver at all
>
Good idea this different SoC extra logic could avoided by add constraints
to .yaml, also code will be more elegant.
I will do this in next version.
> [...]
>> - if (i == USB2_OTG_PHY) {
>> + if (priv->soc_id == MESON_SOC_G12A && i == USB2_OTG_PHY) {
> on GXL we have two PHYs (0 and 1), the second one is OTG capable
> on GXM we have three PHYs (0..2), the second one is OTG capable
> on G12A/G12B we have two PHYs (0 and 1), the second one is OTG capable
>
> you already wrote that there is only one USB2 PHY on the A1 SoC
> is really only the second PHY port ("usb2-phy1" instead of
> "usb2-phy0") used on A1?
> if "usb2-phy0" is correct then you don't need these checks (there are
> more checks like this below)
Actually, A1 have same phys("usb2-phy0", "usb2-phy1", "usb3-phy0") and register base with G12A.
But A1 driver is designed to support host mode with usb2-phy1 only.
>
> [...]
>> - usb_role_switch_unregister(priv->role_switch);
>> + if (priv->soc_id == MESON_SOC_G12A)
>> + usb_role_switch_unregister(priv->role_switch);
> I didn't expect this because in _probe usb_role_switch_register is still called
> on A1 we now call usb_role_switch_register() but we never call
> usb_role_switch_unregister()
>
Actually, usb_role_switch_register() can be called only in G12A.
dwc3_meson_g12a_probe()
...
if (priv->soc_id != MESON_SOC_G12A)
goto setup_pm_runtime;
Same with second suggestion, this different SoC extra logic could avoided by add constraints
to .yaml.
I will do this in next version.
Thanks,
Hanjie
>
> Martin
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
> .
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-01-02 0:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 6:36 [PATCH v3 0/6] arm64: meson: Add support for USB on Amlogic A1 Hanjie Lin
2019-12-27 6:36 ` [PATCH v3 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings Hanjie Lin
2020-01-04 0:28 ` Rob Herring
2020-01-07 2:35 ` Hanjie Lin
2019-12-27 6:36 ` [PATCH v3 2/6] dt-bindings: usb: dwc3: Add the Amlogic A1 Family DWC3 Glue Bindings Hanjie Lin
2020-01-04 0:32 ` Rob Herring
2020-01-07 2:43 ` Hanjie Lin
2019-12-27 6:36 ` [PATCH v3 3/6] phy: amlogic: Add Amlogic A1 USB2 PHY Driver Hanjie Lin
2019-12-27 16:40 ` Martin Blumenstingl
2020-01-02 0:10 ` Hanjie Lin
2019-12-28 2:53 ` Chunfeng Yun
2020-01-02 0:12 ` Hanjie Lin
2019-12-27 6:36 ` [PATCH v3 4/6] usb: dwc3: Add Amlogic A1 DWC3 glue Hanjie Lin
2019-12-27 16:38 ` Martin Blumenstingl
2020-01-02 0:30 ` Hanjie Lin [this message]
2020-01-02 21:52 ` Martin Blumenstingl
2019-12-27 6:36 ` [PATCH v3 5/6] arm64: dts: meson: a1: Enable USB2 PHY Hanjie Lin
2019-12-27 6:36 ` [PATCH v3 6/6] arm64: dts: meson: a1: Enable DWC3 controller Hanjie Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d66abc21-1440-503b-3515-6c495bf0db80@amlogic.com \
--to=hanjie.lin@amlogic.com \
--cc=carlo@caione.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=narmstrong@baylibre.com \
--cc=qiufang.dai@amlogic.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=victor.wan@amlogic.com \
--cc=xingyu.chen@amlogic.com \
--cc=yue.wang@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).