From: Neil Armstrong <narmstrong@baylibre.com>
To: Mohammad Rasim <mohammad.rasim96@gmail.com>,
linux-amlogic@lists.infradead.org,
linux-bluetooth@vger.kernel.org,
Johan Hedberg <johan.hedberg@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [RFC PATCH 4/4] Bluetooth: btbcm: Add entry for BCM4335A0 UART bluetooth
Date: Mon, 18 Nov 2019 11:04:57 +0100 [thread overview]
Message-ID: <de37f562-77eb-755d-5f27-c534ec028356@baylibre.com> (raw)
In-Reply-To: <20191117175606.5050-5-mohammad.rasim96@gmail.com>
On 17/11/2019 18:56, Mohammad Rasim wrote:
> This patch adds the device ID for the BCM4335A0 module (part of the AMPAK AP6335 WIFI/Bluetooth combo)
>
> hciconfig output:
> ```
> hci1: Type: Primary Bus: UART
> BD Address: 43:35:B0:07:1F:AC ACL MTU: 1021:8 SCO MTU: 64:1
> UP RUNNING
> RX bytes:5079 acl:0 sco:0 events:567 errors:0
> TX bytes:69065 acl:0 sco:0 commands:567 errors:0
> Features: 0xbf 0xfe 0xcf 0xff 0xdf 0xff 0x7b 0x87
> Packet type: DM1 DM3 DM5 DH1 DH3 DH5 HV1 HV2 HV3
> Link policy: RSWITCH SNIFF
> Link mode: SLAVE ACCEPT
> Name: 'alarm'
> Class: 0x000000
> Service Classes: Unspecified
> Device Class: Miscellaneous,
> HCI Version: 4.0 (0x6) Revision: 0x161
> LMP Version: 4.0 (0x6) Subversion: 0x4106
> Manufacturer: Broadcom Corporation (15)
> ```
>
> Signed-off-by: Mohammad Rasim <mohammad.rasim96@gmail.com>
> ---
> drivers/bluetooth/btbcm.c | 1 +
> drivers/bluetooth/hci_bcm.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
> index 2d2e6d862068..22464bf8cda3 100644
> --- a/drivers/bluetooth/btbcm.c
> +++ b/drivers/bluetooth/btbcm.c
> @@ -339,6 +339,7 @@ static const struct bcm_subver_table bcm_uart_subver_table[] = {
> { 0x220e, "BCM20702A1" }, /* 001.002.014 */
> { 0x4217, "BCM4329B1" }, /* 002.002.023 */
> { 0x6106, "BCM4359C0" }, /* 003.001.006 */
> + { 0x4106, "BCM4335A0" }, /* 002.001.006 */
Ack for this one
> { }
> };
>
> diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
> index 7646636f2d18..7eba10b0ae6c 100644
> --- a/drivers/bluetooth/hci_bcm.c
> +++ b/drivers/bluetooth/hci_bcm.c
> @@ -1422,6 +1422,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
> { .compatible = "brcm,bcm4345c5" },
> { .compatible = "brcm,bcm4330-bt" },
> { .compatible = "brcm,bcm43438-bt" },
> + { .compatible = "brcm,bcm4335a0" },
This could be omitted if the I/F is the same as "brcm,bcm43438-bt".
> { },
> };
> MODULE_DEVICE_TABLE(of, bcm_bluetooth_of_match);
>
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2019-11-18 10:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 17:56 [RFC v2 PATCH 0/4] add support for videostrong KII Pro Mohammad Rasim
2019-11-17 17:56 ` [RFC PATCH 1/4] dt-bindings: Add vendor prefix for Videostrong Technology Co., Ltd Mohammad Rasim
2019-11-18 10:03 ` Neil Armstrong
2019-11-17 17:56 ` [RFC PATCH 2/4] dt-bindings: net: Add compatible for BCM4335A0 bluetooth module Mohammad Rasim
2019-11-18 10:03 ` Neil Armstrong
2019-11-18 17:53 ` Mohammad Rasim
2019-11-17 17:56 ` [RFC PATCH 3/4] arm64: dts: meson-gxbb: add support for Videostrong KII Pro Mohammad Rasim
2019-11-18 10:26 ` Neil Armstrong
2019-11-18 19:21 ` Mohammad Rasim
2019-11-17 17:56 ` [RFC PATCH 4/4] Bluetooth: btbcm: Add entry for BCM4335A0 UART bluetooth Mohammad Rasim
2019-11-18 10:04 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de37f562-77eb-755d-5f27-c534ec028356@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=johan.hedberg@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mohammad.rasim96@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).