From: Christoph Hellwig <hch@infradead.org>
To: Andy Lutomirski <luto@kernel.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [PATCH] Document that PF_KTHREAD _is_ ABI
Date: Mon, 22 Mar 2021 07:53:10 +0000 [thread overview]
Message-ID: <20210322075310.GA1946905@infradead.org> (raw)
In-Reply-To: <CALCETrUPAvUOr8V5db0gu5RKVftKFwbBEkh6Aob57v+D-xdEig@mail.gmail.com>
On Sat, Mar 20, 2021 at 10:23:12AM -0700, Andy Lutomirski wrote:
> > https://github.com/systemd/systemd/blob/main/src/basic/process-util.c#L354
> > src/basic/process-util.c:is_kernel_thread()
>
> Eww.
>
> Could we fix it differently and more permanently by modifying the proc
> code to display the values systemd expects?
Yes, do_task_stat needs a mapping from kernel flags to UABI flags. And
we should already discard everything we think we can from the UABI
now, and only add the ones back that are required to not break
userspace.
next prev parent reply other threads:[~2021-03-22 7:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 16:30 [PATCH] Document that PF_KTHREAD _is_ ABI Alexey Dobriyan
2021-03-20 17:23 ` Andy Lutomirski
2021-03-20 17:39 ` Alexey Dobriyan
2021-03-20 19:20 ` Florian Weimer
2021-03-22 7:53 ` Christoph Hellwig [this message]
2021-03-31 19:23 ` Alexey Dobriyan
2021-04-01 15:05 ` Stefan Metzmacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322075310.GA1946905@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).