From: Guo Ren <guoren@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Eddy Wu <Eddy_Wu@trendmicro.com>,
x86@kernel.org, "David S . Miller" <davem@davemloft.net>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
"Naveen N . Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
linux-arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH v3 06/16] csky: kprobes: Use generic kretprobe trampoline handler
Date: Fri, 28 Aug 2020 20:34:22 +0800 [thread overview]
Message-ID: <CAJF2gTR5z87fb4ieOcrnMNT6GxSAhj99cf7draGVaHnk7G-pCQ@mail.gmail.com> (raw)
In-Reply-To: <159854636764.736475.9112286781925119117.stgit@devnote2>
Looks more clear.
Acked-by: Guo Ren <guoren@kernel.org>
On Fri, Aug 28, 2020 at 12:39 AM Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> arch/csky/kernel/probes/kprobes.c | 78 +------------------------------------
> 1 file changed, 3 insertions(+), 75 deletions(-)
>
> diff --git a/arch/csky/kernel/probes/kprobes.c b/arch/csky/kernel/probes/kprobes.c
> index f0f733b7ac5a..a891fb422e76 100644
> --- a/arch/csky/kernel/probes/kprobes.c
> +++ b/arch/csky/kernel/probes/kprobes.c
> @@ -404,87 +404,15 @@ int __init arch_populate_kprobe_blacklist(void)
>
> void __kprobes __used *trampoline_probe_handler(struct pt_regs *regs)
> {
> - struct kretprobe_instance *ri = NULL;
> - struct hlist_head *head, empty_rp;
> - struct hlist_node *tmp;
> - unsigned long flags, orig_ret_address = 0;
> - unsigned long trampoline_address =
> - (unsigned long)&kretprobe_trampoline;
> - kprobe_opcode_t *correct_ret_addr = NULL;
> -
> - INIT_HLIST_HEAD(&empty_rp);
> - kretprobe_hash_lock(current, &head, &flags);
> -
> - /*
> - * It is possible to have multiple instances associated with a given
> - * task either because multiple functions in the call path have
> - * return probes installed on them, and/or more than one
> - * return probe was registered for a target function.
> - *
> - * We can handle this because:
> - * - instances are always pushed into the head of the list
> - * - when multiple return probes are registered for the same
> - * function, the (chronologically) first instance's ret_addr
> - * will be the real return address, and all the rest will
> - * point to kretprobe_trampoline.
> - */
> - hlist_for_each_entry_safe(ri, tmp, head, hlist) {
> - if (ri->task != current)
> - /* another task is sharing our hash bucket */
> - continue;
> -
> - orig_ret_address = (unsigned long)ri->ret_addr;
> -
> - if (orig_ret_address != trampoline_address)
> - /*
> - * This is the real return address. Any other
> - * instances associated with this task are for
> - * other calls deeper on the call stack
> - */
> - break;
> - }
> -
> - kretprobe_assert(ri, orig_ret_address, trampoline_address);
> -
> - correct_ret_addr = ri->ret_addr;
> - hlist_for_each_entry_safe(ri, tmp, head, hlist) {
> - if (ri->task != current)
> - /* another task is sharing our hash bucket */
> - continue;
> -
> - orig_ret_address = (unsigned long)ri->ret_addr;
> - if (ri->rp && ri->rp->handler) {
> - __this_cpu_write(current_kprobe, &ri->rp->kp);
> - get_kprobe_ctlblk()->kprobe_status = KPROBE_HIT_ACTIVE;
> - ri->ret_addr = correct_ret_addr;
> - ri->rp->handler(ri, regs);
> - __this_cpu_write(current_kprobe, NULL);
> - }
> -
> - recycle_rp_inst(ri, &empty_rp);
> -
> - if (orig_ret_address != trampoline_address)
> - /*
> - * This is the real return address. Any other
> - * instances associated with this task are for
> - * other calls deeper on the call stack
> - */
> - break;
> - }
> -
> - kretprobe_hash_unlock(current, &flags);
> -
> - hlist_for_each_entry_safe(ri, tmp, &empty_rp, hlist) {
> - hlist_del(&ri->hlist);
> - kfree(ri);
> - }
> - return (void *)orig_ret_address;
> + return (void *)kretprobe_trampoline_handler(regs,
> + (unsigned long)&kretprobe_trampoline, NULL);
> }
>
> void __kprobes arch_prepare_kretprobe(struct kretprobe_instance *ri,
> struct pt_regs *regs)
> {
> ri->ret_addr = (kprobe_opcode_t *)regs->lr;
> + ri->fp = NULL;
> regs->lr = (unsigned long) &kretprobe_trampoline;
> }
>
>
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
next prev parent reply other threads:[~2020-08-28 12:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 16:38 [PATCH v3 00/16] kprobes: Unify kretprobe trampoline handlers Masami Hiramatsu
2020-08-27 16:38 ` [PATCH v3 01/16] kprobes: Add generic kretprobe trampoline handler Masami Hiramatsu
2020-08-28 1:57 ` Masami Hiramatsu
2020-08-27 16:38 ` [PATCH v3 02/16] x86/kprobes: Use " Masami Hiramatsu
2020-08-27 16:39 ` [PATCH v3 03/16] arm: kprobes: " Masami Hiramatsu
2020-08-27 16:39 ` [PATCH v3 04/16] arm64: " Masami Hiramatsu
2020-08-27 16:39 ` [PATCH v3 05/16] arc: " Masami Hiramatsu
2020-08-27 16:39 ` [PATCH v3 06/16] csky: " Masami Hiramatsu
2020-08-28 12:34 ` Guo Ren [this message]
2020-08-29 9:31 ` Masami Hiramatsu
2020-08-27 16:39 ` [PATCH v3 07/16] ia64: " Masami Hiramatsu
2020-08-27 16:39 ` [PATCH v3 08/16] mips: " Masami Hiramatsu
2020-08-27 16:39 ` [PATCH v3 09/16] parisc: " Masami Hiramatsu
2020-08-27 16:40 ` [PATCH v3 10/16] powerpc: " Masami Hiramatsu
2020-08-27 16:40 ` [PATCH v3 11/16] s390: " Masami Hiramatsu
2020-08-27 16:40 ` [PATCH v3 12/16] sh: " Masami Hiramatsu
2020-08-27 16:40 ` [PATCH v3 13/16] sparc: " Masami Hiramatsu
2020-08-27 16:40 ` [PATCH v3 14/16] kprobes: Remove NMI context check Masami Hiramatsu
2020-08-27 16:40 ` [PATCH v3 15/16] kprobes: Free kretprobe_instance with rcu callback Masami Hiramatsu
2020-08-27 16:40 ` [PATCH v3 16/16] kprobes: Make local used functions static Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTR5z87fb4ieOcrnMNT6GxSAhj99cf7draGVaHnk7G-pCQ@mail.gmail.com \
--to=guoren@kernel.org \
--cc=Eddy_Wu@trendmicro.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).