From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F067CC433E9 for ; Fri, 5 Mar 2021 15:52:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B51F565093 for ; Fri, 5 Mar 2021 15:52:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229651AbhCEPvr (ORCPT ); Fri, 5 Mar 2021 10:51:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:55844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbhCEPv0 (ORCPT ); Fri, 5 Mar 2021 10:51:26 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 763CE65098; Fri, 5 Mar 2021 15:51:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614959485; bh=xaeKME6Ua+2h67Q5RJolMrcXStqSWyB8CTRElNWIdNw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=rRBl/eyvNDoud0LUtrcLX3ZHlvFGYju9nRGC39q3t+sL/avqv7YMNUYtgGz+64bC4 ba8t52YZcQZP3AD6bZ40jv96cX+sdGEI0xEQY69Fbif8/ZX1LK24REnFh0qun1HSu0 5IczDBfK5rRw7HW1wAcDu2AahDGioeTqPBOqmZTXY20PjFiFwdylWietKbwwJKWI9O Uk8JbPVhPc8ueXo/5GNzJcCWtvuK07/7q06/fB7srsrwWAEMz62zIBsYjdlgx7dQU9 7StWGQz91kPVR5yitBRxn8gdnBYy3vcdj8DLTrS8breER6uZJnWc2M72edeVGicex9 VEiPkVgxaxidQ== Received: by mail-ot1-f44.google.com with SMTP id j8so2244956otc.0; Fri, 05 Mar 2021 07:51:25 -0800 (PST) X-Gm-Message-State: AOAM5326SrXlvMIBpYRMXBOye3ZeFynQj4E8mh7z7mkwHAadR9s876Cu wzR+KylaFjbfe9TeKm4xa09dUXKqy3CUkBcPyvY= X-Google-Smtp-Source: ABdhPJy9oV+4qLl47P+rrukasKtK8n7azdZjxa8hAXJBGcPPcFGMLNqAWqsBN3UFc1UFX0r7zYKKwNbJzSCj+keSlF4= X-Received: by 2002:a9d:12e1:: with SMTP id g88mr5226195otg.305.1614959484753; Fri, 05 Mar 2021 07:51:24 -0800 (PST) MIME-Version: 1.0 References: <20210304213902.83903-1-marcan@marcan.st> <20210304213902.83903-11-marcan@marcan.st> In-Reply-To: From: Arnd Bergmann Date: Fri, 5 Mar 2021 16:51:08 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT PATCH v3 10/27] docs: driver-api: device-io: Document ioremap() variants & access funcs To: Andy Shevchenko Cc: Linus Walleij , Hector Martin , Linux ARM , Marc Zyngier , Rob Herring , Olof Johansson , Krzysztof Kozlowski , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Mark Rutland , Greg Kroah-Hartman , Jonathan Corbet , Catalin Marinas , Christoph Hellwig , "David S. Miller" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:SERIAL DRIVERS" , Linux Doc Mailing List , linux-samsung-soc , Linux-Arch , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Fri, Mar 5, 2021 at 4:09 PM Andy Shevchenko wrote: > On Fri, Mar 5, 2021 at 12:25 PM Linus Walleij wrote: > > On Thu, Mar 4, 2021 at 10:40 PM Hector Martin wrote: > > > > > This documents the newly introduced ioremap_np() along with all the > > > other common ioremap() variants, and some higher-level abstractions > > > available. > > > > > > Signed-off-by: Hector Martin > > > > I like this, I just want one change: > > > > Put the common ioremap() on top in all paragraphs, so the norm > > comes before the exceptions. > > > > I.e. it is weird to mention ioremap_np() before mentioning ioremap(). > > +1 here. That is what I have stumbled upon reading carefully. In that case, the order should probably be: ioremap ioremap_wc ioremap_wt ioremap_np ioremap_uc ioremap_cache Going from most common to least common, rather than going from strongest to weakest. Arnd