From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Nicholas Piggin <npiggin@gmail.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Arnd Bergmann <arnd@arndb.de>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH v3 03/23] arc: use asm-generic/mmu_context.h for no-op implementations
Date: Tue, 1 Sep 2020 18:32:15 +0000 [thread overview]
Message-ID: <d6d24a21-dd08-73ad-9707-0ee341ecda7b@synopsys.com> (raw)
In-Reply-To: <20200901141539.1757549-4-npiggin@gmail.com>
On 9/1/20 7:15 AM, Nicholas Piggin wrote:
> Cc: Vineet Gupta <vgupta@synopsys.com>
> Cc: linux-snps-arc@lists.infradead.org
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Acked-by: Vineet Gupta <vgupta@synopsys.com> #arch/arc
Thx,
-Vineet
> ---
>
> Please ack or nack if you object to this being mered via
> Arnd's tree.
>
> arch/arc/include/asm/mmu_context.h | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arc/include/asm/mmu_context.h b/arch/arc/include/asm/mmu_context.h
> index 3a5e6a5b9ed6..df164066e172 100644
> --- a/arch/arc/include/asm/mmu_context.h
> +++ b/arch/arc/include/asm/mmu_context.h
> @@ -102,6 +102,7 @@ static inline void get_new_mmu_context(struct mm_struct *mm)
> * Initialize the context related info for a new mm_struct
> * instance.
> */
> +#define init_new_context init_new_context
> static inline int
> init_new_context(struct task_struct *tsk, struct mm_struct *mm)
> {
> @@ -113,6 +114,7 @@ init_new_context(struct task_struct *tsk, struct mm_struct *mm)
> return 0;
> }
>
> +#define destroy_context destroy_context
> static inline void destroy_context(struct mm_struct *mm)
> {
> unsigned long flags;
> @@ -153,13 +155,13 @@ static inline void switch_mm(struct mm_struct *prev, struct mm_struct *next,
> }
>
> /*
> - * Called at the time of execve() to get a new ASID
> - * Note the subtlety here: get_new_mmu_context() behaves differently here
> - * vs. in switch_mm(). Here it always returns a new ASID, because mm has
> - * an unallocated "initial" value, while in latter, it moves to a new ASID,
> - * only if it was unallocated
> + * activate_mm defaults (in asm-generic) to switch_mm and is called at the
> + * time of execve() to get a new ASID Note the subtlety here:
> + * get_new_mmu_context() behaves differently here vs. in switch_mm(). Here
> + * it always returns a new ASID, because mm has an unallocated "initial"
> + * value, while in latter, it moves to a new ASID, only if it was
> + * unallocated
> */
> -#define activate_mm(prev, next) switch_mm(prev, next, NULL)
>
> /* it seemed that deactivate_mm( ) is a reasonable place to do book-keeping
> * for retiring-mm. However destroy_context( ) still needs to do that because
> @@ -168,8 +170,7 @@ static inline void switch_mm(struct mm_struct *prev, struct mm_struct *next,
> * there is a good chance that task gets sched-out/in, making it's ASID valid
> * again (this teased me for a whole day).
> */
> -#define deactivate_mm(tsk, mm) do { } while (0)
>
> -#define enter_lazy_tlb(mm, tsk)
> +#include <asm-generic/mmu_context.h>
>
> #endif /* __ASM_ARC_MMU_CONTEXT_H */
>
next prev parent reply other threads:[~2020-09-01 18:32 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 14:15 [PATCH v3 00/23] Use asm-generic for mmu_context no-op functions Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 01/23] asm-generic: add generic MMU versions of mmu context functions Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 02/23] alpha: use asm-generic/mmu_context.h for no-op implementations Nicholas Piggin
2020-09-01 16:51 ` Matt Turner
2020-09-01 14:15 ` [PATCH v3 03/23] arc: " Nicholas Piggin
2020-09-01 18:32 ` Vineet Gupta [this message]
2020-09-01 14:15 ` [PATCH v3 04/23] arm: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 05/23] arm64: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 06/23] csky: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 07/23] hexagon: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 08/23] ia64: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 09/23] m68k: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 10/23] microblaze: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 11/23] mips: " Nicholas Piggin
2020-09-01 15:23 ` Thomas Bogendoerfer
2020-09-01 14:15 ` [PATCH v3 12/23] nds32: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 13/23] nios2: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 14/23] openrisc: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 15/23] parisc: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 16/23] powerpc: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 17/23] riscv: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 18/23] s390: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 19/23] sh: " Nicholas Piggin
2020-09-03 5:57 ` Rich Felker
2020-09-01 14:15 ` [PATCH v3 20/23] sparc: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 21/23] um: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 22/23] x86: " Nicholas Piggin
2020-09-01 14:15 ` [PATCH v3 23/23] xtensa: " Nicholas Piggin
2020-09-01 17:55 ` Max Filippov
2020-09-09 11:27 ` [PATCH v3 00/23] Use asm-generic for mmu_context no-op functions Arnd Bergmann
2020-10-09 14:01 ` Arnd Bergmann
2020-10-10 2:02 ` Stephen Rothwell
2020-10-10 8:25 ` Arnd Bergmann
2020-10-10 19:00 ` Stephen Rothwell
2020-10-19 1:00 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6d24a21-dd08-73ad-9707-0ee341ecda7b@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).