From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation the default
Date: Thu, 11 Aug 2011 21:02:45 +0900 [thread overview]
Message-ID: <000501cc581e$95ecf7a0$c1c6e6e0$%kim@samsung.com> (raw)
In-Reply-To: <E1QqhMg-0003an-GW@rmk-PC.arm.linux.org.uk>
Russell King - ARM Linux wrote:
>
> Rather than marking the mach/gpio.h header files which want to use the
> trivial GPIOLIB implementation, mark those which do not want to use it
> instead. This means that by default, you get the trivial implementation
> and only have to do something extra if you need to. This should
> encourage the use of the trivial default implementation.
>
> As an additional bonus, several gpio.h header files become empty.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Looks good to me :)
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
on following Samsung stuff...
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
> ---
> arch/arm/include/asm/gpio.h | 2 +-
> arch/arm/mach-exynos4/include/mach/gpio.h | 2 --
> arch/arm/mach-s3c2410/include/mach/gpio.h | 2 --
> arch/arm/mach-s3c64xx/include/mach/gpio.h | 2 --
> arch/arm/mach-s5p64x0/include/mach/gpio.h | 2 --
> arch/arm/mach-s5pc100/include/mach/gpio.h | 2 --
> arch/arm/mach-s5pv210/include/mach/gpio.h | 2 --
>
> diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h
> index 5032224..11ad0bf 100644
> --- a/arch/arm/include/asm/gpio.h
> +++ b/arch/arm/include/asm/gpio.h
> @@ -4,7 +4,7 @@
> /* not all ARM platforms necessarily support this API ... */
> #include <mach/gpio.h>
>
> -#ifdef __ARM_GPIOLIB_TRIVIAL
> +#ifndef __ARM_GPIOLIB_COMPLEX
> /* Note: this may rely upon the value of ARCH_NR_GPIOS set in mach/gpio.h
*/
> #include <asm-generic/gpio.h>
>
> diff --git a/arch/arm/mach-exynos4/include/mach/gpio.h b/arch/arm/mach-
> exynos4/include/mach/gpio.h
> index b91e8b2..80523ca 100644
> --- a/arch/arm/mach-exynos4/include/mach/gpio.h
> +++ b/arch/arm/mach-exynos4/include/mach/gpio.h
> @@ -146,6 +146,4 @@ enum s5p_gpio_number {
> #define ARCH_NR_GPIOS
> (EXYNOS4_GPZ(EXYNOS4_GPIO_Z_NR) + \
> CONFIG_SAMSUNG_GPIO_EXTRA + 1)
>
> -#define __ARM_GPIOLIB_TRIVIAL
> -
> #endif /* __ASM_ARCH_GPIO_H */
> diff --git a/arch/arm/mach-s3c2410/include/mach/gpio.h b/arch/arm/mach-
> s3c2410/include/mach/gpio.h
> index d502d17..6fac70f 100644
> --- a/arch/arm/mach-s3c2410/include/mach/gpio.h
> +++ b/arch/arm/mach-s3c2410/include/mach/gpio.h
> @@ -11,8 +11,6 @@
> * published by the Free Software Foundation.
> */
>
> -#define __ARM_GPIOLIB_TRIVIAL
> -
> /* some boards require extra gpio capacity to support external
> * devices that need GPIO.
> */
> diff --git a/arch/arm/mach-s3c64xx/include/mach/gpio.h b/arch/arm/mach-
> s3c64xx/include/mach/gpio.h
> index 3a8857c..6e34c2f 100644
> --- a/arch/arm/mach-s3c64xx/include/mach/gpio.h
> +++ b/arch/arm/mach-s3c64xx/include/mach/gpio.h
> @@ -12,8 +12,6 @@
> * published by the Free Software Foundation.
> */
>
> -#define __ARM_GPIOLIB_TRIVIAL
> -
> /* GPIO bank sizes */
> #define S3C64XX_GPIO_A_NR (8)
> #define S3C64XX_GPIO_B_NR (7)
> diff --git a/arch/arm/mach-s5p64x0/include/mach/gpio.h b/arch/arm/mach-
> s5p64x0/include/mach/gpio.h
> index c3a6aa0..06cd3c9 100644
> --- a/arch/arm/mach-s5p64x0/include/mach/gpio.h
> +++ b/arch/arm/mach-s5p64x0/include/mach/gpio.h
> @@ -13,8 +13,6 @@
> #ifndef __ASM_ARCH_GPIO_H
> #define __ASM_ARCH_GPIO_H __FILE__
>
> -#define __ARM_GPIOLIB_TRIVIAL
> -
> /* GPIO bank sizes */
>
> #define S5P6440_GPIO_A_NR (6)
> diff --git a/arch/arm/mach-s5pc100/include/mach/gpio.h b/arch/arm/mach-
> s5pc100/include/mach/gpio.h
> index 0e75641..5e1a924 100644
> --- a/arch/arm/mach-s5pc100/include/mach/gpio.h
> +++ b/arch/arm/mach-s5pc100/include/mach/gpio.h
> @@ -15,8 +15,6 @@
> #ifndef __ASM_ARCH_GPIO_H
> #define __ASM_ARCH_GPIO_H __FILE__
>
> -#define __ARM_GPIOLIB_TRIVIAL
> -
> /* GPIO bank sizes */
> #define S5PC100_GPIO_A0_NR (8)
> #define S5PC100_GPIO_A1_NR (5)
> diff --git a/arch/arm/mach-s5pv210/include/mach/gpio.h b/arch/arm/mach-
> s5pv210/include/mach/gpio.h
> index d348ee2..6c8b903 100644
> --- a/arch/arm/mach-s5pv210/include/mach/gpio.h
> +++ b/arch/arm/mach-s5pv210/include/mach/gpio.h
> @@ -13,8 +13,6 @@
> #ifndef __ASM_ARCH_GPIO_H
> #define __ASM_ARCH_GPIO_H __FILE__
>
> -#define __ARM_GPIOLIB_TRIVIAL
> -
> /* Practically, GPIO banks up to MP03 are the configurable gpio banks */
>
> /* GPIO bank sizes */
next prev parent reply other threads:[~2011-08-11 12:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 8:04 [PATCH 00/13] Clean up mach/gpio.h headers Russell King - ARM Linux
2011-08-09 8:04 ` [PATCH 01/13] ARM: gpio: at91: remove redundant include of mach/gpio.h Russell King - ARM Linux
2011-08-09 8:05 ` [PATCH 02/13] ARM: gpio: convert includes of mach/gpio.h and asm/gpio.h to linux/gpio.h Russell King - ARM Linux
2011-08-09 8:05 ` [PATCH 03/13] ARM: gpio: omap: convert drivers to use asm/gpio.h rather than mach/gpio.h Russell King - ARM Linux
2011-08-29 18:20 ` Kevin Hilman
2011-08-09 8:05 ` [PATCH 04/13] ARM: gpio: at91: " Russell King - ARM Linux
2011-08-09 8:06 ` [PATCH 05/13] ARM: gpio: nomadik: " Russell King - ARM Linux
2011-08-09 8:06 ` [PATCH 06/13] ARM: gpio: davinci: " Russell King - ARM Linux
2011-08-09 12:06 ` Sergei Shtylyov
2011-08-09 19:45 ` Russell King - ARM Linux
2011-08-09 8:06 ` [PATCH 07/13] ARM: gpio: pnx4008: " Russell King - ARM Linux
2011-08-09 8:07 ` [PATCH 08/13] ARM: gpio: ixp2000: " Russell King - ARM Linux
2011-08-09 8:07 ` [PATCH 09/13] ARM: gpio: tegra: " Russell King - ARM Linux
2011-08-09 8:07 ` [PATCH 10/13] ARM: gpio: pxa: " Russell King - ARM Linux
2011-08-09 8:08 ` [PATCH 11/13] ARM: gpio: consolidate trivial gpiolib implementations Russell King - ARM Linux
2011-08-09 17:02 ` H Hartley Sweeten
2011-08-09 17:59 ` David Brown
2011-08-10 7:54 ` Linus Walleij
2011-08-11 11:47 ` Kukjin Kim
2011-08-11 15:08 ` Russell King - ARM Linux
2011-08-11 16:24 ` David Brown
2011-08-11 14:15 ` Felipe Balbi
2011-08-11 15:07 ` Russell King - ARM Linux
2011-08-11 18:50 ` Felipe Balbi
2011-08-12 5:54 ` Shawn Guo
2011-08-29 18:23 ` Kevin Hilman
2011-08-09 8:08 ` [PATCH 12/13] ARM: gpio: consolidate gpio_to_irq Russell King - ARM Linux
2011-08-11 11:58 ` Kukjin Kim
2011-08-09 8:08 ` [PATCH 13/13] ARM: gpio: make trivial GPIOLIB implementation the default Russell King - ARM Linux
2011-08-09 17:04 ` H Hartley Sweeten
2011-08-11 12:02 ` Kukjin Kim [this message]
2011-08-09 9:58 ` [PATCH 00/13] Clean up mach/gpio.h headers Jamie Iles
2011-08-09 21:00 ` Grant Likely
2011-08-09 21:32 ` Russell King - ARM Linux
2011-08-09 21:50 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000501cc581e$95ecf7a0$c1c6e6e0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).