linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: saiprakash.ranjan@codeaurora.org, mathieu.poirier@linaro.org,
	leo.yan@linaro.org, alexander.shishkin@linux.intel.com,
	david.brown@linaro.org, mark.rutland@arm.com
Cc: rnayak@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, sibis@codeaurora.org,
	vivek.gautam@codeaurora.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] coresight: Abort probe for missing CPU phandle
Date: Thu, 20 Jun 2019 16:23:51 +0100	[thread overview]
Message-ID: <0182216b-5495-bcf7-bb0e-869133b24830@arm.com> (raw)
In-Reply-To: <e3e13629-a723-8b08-cbae-5a3295170900@codeaurora.org>



On 20/06/2019 15:55, Sai Prakash Ranjan wrote:
> On 6/20/2019 7:28 PM, Suzuki K Poulose wrote:
>>
>>
>> On 20/06/2019 14:45, Sai Prakash Ranjan wrote:
>>> Currently the coresight etm and cpu-debug drivers
>>> assume the affinity to CPU0 returned by coresight
>>> platform and continue the probe in case of missing
>>> CPU phandle. This is not true and leads to crash
>>> in some cases, so abort the probe in case of missing
>>> CPU phandle.
>>>
>>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>>> ---
>>>    drivers/hwtracing/coresight/coresight-cpu-debug.c | 3 +++
>>>    drivers/hwtracing/coresight/coresight-etm3x.c     | 3 +++
>>>    drivers/hwtracing/coresight/coresight-etm4x.c     | 3 +++
>>>    3 files changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c
>>> b/drivers/hwtracing/coresight/coresight-cpu-debug.c
>>> index 07a1367c733f..43f32fa71ff9 100644
>>> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
>>> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
>>> @@ -579,6 +579,9 @@ static int debug_probe(struct amba_device *adev,
>>> const struct amba_id *id)
>>>            return -ENOMEM;
>>>        drvdata->cpu = coresight_get_cpu(dev);
>>> +    if (drvdata->cpu == -ENODEV)
>>> +        return -ENODEV;
>>
>> if (drvdata->cpu < 0)
>>       return drvdata->cpu;
>>
>> Same everywhere below ?
>>
>> Also, I would like to hear Mathieu's thoughts on this change. If he's OK
>> with it:
>>
>> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> with the change
>> above.
>>
>>
> 
> Thanks, I will make the change and repost.

Please wait for Mathieu's thoughts on it. And in general I would wait
for feedback from the people in a version, before posting another one,
to reduce the number of respins.

Cheers
Suzuki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-06-20 15:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20 13:45 [PATCH 0/2] coresight: Set affinity to invalid for missing CPU phandle Sai Prakash Ranjan
2019-06-20 13:45 ` [PATCH 1/2] " Sai Prakash Ranjan
2019-06-20 13:55   ` Suzuki K Poulose
2019-06-20 14:54     ` Sai Prakash Ranjan
2019-06-20 17:39   ` Mathieu Poirier
2019-06-20 18:05     ` Sai Prakash Ranjan
2019-06-20 13:45 ` [PATCH 2/2] coresight: Abort probe " Sai Prakash Ranjan
2019-06-20 13:58   ` Suzuki K Poulose
2019-06-20 14:55     ` Sai Prakash Ranjan
2019-06-20 15:23       ` Suzuki K Poulose [this message]
2019-06-20 16:10         ` Sai Prakash Ranjan
2019-06-20 17:43   ` Mathieu Poirier
2019-06-20 18:07     ` Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0182216b-5495-bcf7-bb0e-869133b24830@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=david.brown@linaro.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=rnayak@codeaurora.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=sibis@codeaurora.org \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).