From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Zhiyong Tao <zhiyong.tao@mediatek.com>,
lee.jones@linaro.org, robh+dt@kernel.org, matthias.bgg@gmail.com,
lgirdwood@gmail.com, broonie@kernel.org,
eddie.huang@mediatek.com, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, fshao@chromium.org
Cc: sen.chu@mediatek.com, hui.liu@mediatek.com,
allen-kh.cheng@mediatek.com, hsin-hsiung.wang@mediatek.com,
sean.wang@mediatek.com, macpaul.lin@mediatek.com,
wen.su@mediatek.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
zhiyong tao <zhiyong.tao@mediatk.com>
Subject: Re: [PATCH v2] pmic: add mt6366 regulator document
Date: Thu, 28 Jul 2022 12:46:51 +0200 [thread overview]
Message-ID: <03a13ed4-e7cd-6f7d-f8f7-9b1e6193e202@linaro.org> (raw)
In-Reply-To: <20220728062749.18701-2-zhiyong.tao@mediatek.com>
On 28/07/2022 08:27, Zhiyong Tao wrote:
> From: zhiyong tao <zhiyong.tao@mediatek.com>
>
> Add mt6366 regulator document
As usual with Mediatek your emails fail to properly pass modern SMTP
checks and you end up in spam.
I reported it months ago to folks in Mediatek. No improvements since
that time.
I stopped checking my spam folder for Mediatek stuff and all will be
ignored. I will also stop complaining about it - just ignore Mediatek.
Fix your systems, instead of putting additional effort on community and
on reviewers.
>
> Signed-off-by: zhiyong tao <zhiyong.tao@mediatk.com>
> ---
> .../regulator/mediatek,mt6366-regulator.yaml | 375 ++++++++++++++++++
> 1 file changed, 375 insertions(+)
Subject does not match subsystem.
> create mode 100755 Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml
> new file mode 100755
> index 000000000000..eb72c64757cf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml
> @@ -0,0 +1,375 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/mediatek,mt6366-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MT6366 Regulator from MediaTek Integrated
> +
> +maintainers:
> + - Zhiyong Tao <zhiyong.tao@mediatek.com>
> +
> +description: |
> + List of regulators provided by this controller. It is named
> + according to its regulator type, buck_<name> and ldo_<name>.
> + MT6366 regulators node should be sub node of the MT6397 MFD node.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6366-regulator
> +
> + regulators:
> + type: object
> + description: List of regulators and its properties
> +
> + patternProperties:
> + "^buck-v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$":
> + type: object
> + $ref: "regulator.yaml#"
No need for quotes.
> + unevaluatedProperties: false
> +
> + properties:
> + regulator-name:
> + pattern: "^v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$"
Why do you enforce specific regulator-name? Remove.
> +
> + "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$":
> + type: object
> + $ref: "regulator.yaml#"
> +
> + properties:
> + regulator-name:
> + pattern: "^v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$"
> +
> + "^ldo-v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$":
> + type: object
> + $ref: "regulator.yaml#"
> +
> + properties:
> + regulator-name:
> + pattern: "^v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$"
> +
> + "^buck-(vcore)-sshub$":
> + type: object
> + $ref: "regulator.yaml#"
> + unevaluatedProperties: false
> +
> + properties:
> + regulator-name:
> + pattern: "^vcore-sshub$"
> +
> + "^ldo-vcn(28|33)-bt$":
> + type: object
> + $ref: "regulator.yaml#"
> + unevaluatedProperties: false
> +
> + properties:
> + regulator-name:
> + pattern: "^vcn(28|33)-bt$"
> +
> + "^ldo-vcn(33)-wifi$":
> + type: object
> + $ref: "regulator.yaml#"
> + unevaluatedProperties: false
> +
> + properties:
> + regulator-name:
> + pattern: "^vcn33-wifi$"
> +
> + "^ldo-vsram-(others)-sshub$":
> + type: object
> + $ref: "regulator.yaml#"
> + unevaluatedProperties: false
> +
> + properties:
> + regulator-name:
> + pattern: "^vsram-others-sshub$"
> +
> + "^ldo-vsram-(proc11|others|gpu|proc12)$":
> + type: object
> + $ref: "regulator.yaml#"
> + unevaluatedProperties: false
> +
> + properties:
> + regulator-name:
> + pattern: "^vsram-(proc11|others|gpu|proc12)$"
> +
> + "^ldo-v(aud|bif|io|ldo)28$":
> + type: object
> + $ref: "regulator.yaml#"
> +
> + properties:
> + regulator-name:
> + pattern: "^v(aud|bif|io|ldo)28$"
> +
> + "^ldo-v(io|aux|rf)18$":
> + type: object
> + $ref: "regulator.yaml#"
> +
> + properties:
> + regulator-name:
> + pattern: "^v(io|aux|rf)18$"
> +
> + "^ldo-vsim[2]$":
> + type: object
> + $ref: "regulator.yaml#"
> +
> + properties:
> + regulator-name:
> + pattern: "^vsim2$"
> +
> + required:
> + - regulator-name
> +
> +required:
> + - compatible
> + - regulators
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pmic {
> + compatible = "mediatek,mt6366-regulator";
> +
> + regulators {
> + mt6366_vdram1_reg: buck-vdram1 {
> + regulator-name = "vdram1";
Messed up indentation. Use only one, so 4 space for DTS example.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-28 10:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 6:27 [PATCH v2 0/1] Mediatek MT6366 Regulator patch Zhiyong Tao
2022-07-28 6:27 ` [PATCH v2] pmic: add mt6366 regulator document Zhiyong Tao
2022-07-28 10:46 ` Krzysztof Kozlowski [this message]
2022-08-03 9:50 ` Rex-BC Chen
2022-08-04 2:31 ` Chen-Yu Tsai
2022-08-04 7:25 ` Krzysztof Kozlowski
2022-08-11 8:42 ` zhiyong.tao
2022-08-11 8:58 ` Krzysztof Kozlowski
2022-08-11 9:14 ` zhiyong.tao
2022-08-11 9:15 ` Krzysztof Kozlowski
2022-08-11 9:18 ` zhiyong.tao
2022-07-28 11:07 ` Mark Brown
2022-08-01 3:23 ` zhiyong.tao
2022-08-01 11:14 ` Mark Brown
2022-07-28 10:59 ` [PATCH v2 0/1] Mediatek MT6366 Regulator patch Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03a13ed4-e7cd-6f7d-f8f7-9b1e6193e202@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=fshao@chromium.org \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=hui.liu@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=sen.chu@mediatek.com \
--cc=wen.su@mediatek.com \
--cc=zhiyong.tao@mediatek.com \
--cc=zhiyong.tao@mediatk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).