From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: f.fainelli@gmail.com, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, wahrenst@gmx.net,
linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
p.zabel@pengutronix.de, linux-gpio@vger.kernel.org,
linus.walleij@linaro.org, linux-clk@vger.kernel.org,
sboyd@kernel.org, linux-rpi-kernel@lists.infradead.org,
bgolaszewski@baylibre.com, andy.shevchenko@gmail.com
Subject: Re: [PATCH v8 11/11] pwm: Add Raspberry Pi Firmware based PWM bus
Date: Mon, 15 Mar 2021 17:12:44 +0100 [thread overview]
Message-ID: <1255e56c66c8704c93adad77f605357267de0231.camel@suse.de> (raw)
In-Reply-To: <20210312201217.n2sav23swy7ii4uo@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 1372 bytes --]
Hi Uwe,
On Fri, 2021-03-12 at 21:12 +0100, Uwe Kleine-König wrote:
> Hello Nicolas,
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright 2020 Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> 2021?
Yes.
> > + * For more information on Raspberry Pi's PoE hat see:
> > + * https://www.raspberrypi.org/products/poe-hat/
>
> Out of personal interest: Is this hat also able to power a RPi CM4?
I haven't tested it, and can't at the moment (no PoE injector available). But
the physical pin layout, and routing in CM4's IO board fits the hat. So I'd say
yes.
> > + * Limitations:
> > + * - No disable bit, so a disabled PWM is simulated by duty_cycle 0
> > + * - Only normal polarity
> > + * - Fixed 12.5 kHz period
> > + *
> > + * The current period is completed when HW is reconfigured.
> > + */
>
> Other than that as mentioned in the previous round: This looks good,
>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks!
> What is your thought about how to get this series merged?
> At least input, staging, armsoc, clk, reset anf firmware are touched. Do you
> prepare a branch for merging in the relevant trees (once you have all the
> necessary Acks)?
As per Linusw suggestion I'll send a pull request myself into the SoC tree and
hope for the best. :)
Regards,
Nicolas
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-15 16:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 12:24 [PATCH v8 00/11] Raspberry Pi PoE HAT fan support Nicolas Saenz Julienne
2021-03-12 12:24 ` [PATCH v8 01/11] firmware: raspberrypi: Keep count of all consumers Nicolas Saenz Julienne
2021-03-12 12:24 ` [PATCH v8 02/11] firmware: raspberrypi: Introduce devm_rpi_firmware_get() Nicolas Saenz Julienne
2021-03-12 12:24 ` [PATCH v8 03/11] clk: bcm: rpi: Release firmware handle on unbind Nicolas Saenz Julienne
2021-03-12 12:24 ` [PATCH v8 04/11] gpio: raspberrypi-exp: " Nicolas Saenz Julienne
2021-03-12 12:24 ` [PATCH v8 05/11] reset: raspberrypi: " Nicolas Saenz Julienne
2021-03-12 12:24 ` [PATCH v8 06/11] soc: bcm: raspberrypi-power: " Nicolas Saenz Julienne
2021-03-12 12:24 ` [PATCH v8 07/11] staging: vchiq: " Nicolas Saenz Julienne
2021-03-12 12:24 ` [PATCH v8 08/11] input: raspberrypi-ts: Release firmware handle when not needed Nicolas Saenz Julienne
2021-03-12 12:24 ` [PATCH v8 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus Nicolas Saenz Julienne
2021-03-12 12:24 ` [PATCH v8 10/11] DO NOT MERGE: ARM: dts: Add RPi's official PoE hat support Nicolas Saenz Julienne
2021-03-12 12:24 ` [PATCH v8 11/11] pwm: Add Raspberry Pi Firmware based PWM bus Nicolas Saenz Julienne
2021-03-12 20:12 ` Uwe Kleine-König
2021-03-15 16:12 ` Nicolas Saenz Julienne [this message]
2021-03-22 11:56 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255e56c66c8704c93adad77f605357267de0231.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=andy.shevchenko@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).