From: Stefan Wahren <wahrenst@gmx.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>, Eric Anholt <eric@anholt.net>,
Thierry Reding <thierry.reding@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] pwm: bcm2835: suppress error message during deferred probe
Date: Sat, 24 Aug 2019 11:44:10 +0200 [thread overview]
Message-ID: <141b0cb0-fa5c-ba3b-12cd-8e8252b1eb4e@gmx.net> (raw)
In-Reply-To: <20190824093032.cunkmukx73vl4hy3@pengutronix.de>
Am 24.08.19 um 11:30 schrieb Uwe Kleine-König:
> On Sat, Aug 24, 2019 at 09:07:25AM +0200, Stefan Wahren wrote:
>> This suppresses error messages in case the PWM clock isn't ready yet.
>>
>> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
>> ---
>> drivers/pwm/pwm-bcm2835.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pwm/pwm-bcm2835.c b/drivers/pwm/pwm-bcm2835.c
>> index 2c82386..ce362be 100644
>> --- a/drivers/pwm/pwm-bcm2835.c
>> +++ b/drivers/pwm/pwm-bcm2835.c
>> @@ -153,7 +153,10 @@ static int bcm2835_pwm_probe(struct platform_device *pdev)
>>
>> pc->clk = devm_clk_get(&pdev->dev, NULL);
>> if (IS_ERR(pc->clk)) {
>> - dev_err(&pdev->dev, "clock not found: %ld\n", PTR_ERR(pc->clk));
>> + if (PTR_ERR(pc->clk) != -EPROBE_DEFER) {
>> + dev_err(&pdev->dev, "clock not found: %ld\n",
>> + PTR_ERR(pc->clk));
>> + }
>> return PTR_ERR(pc->clk);
>> }
> I would have used:
>
> if (IS_ERR(pc->clk)) {
> int err = PTR_ERR(pc->clk);
> if (err != -EPROBE_DEFER)
> dev_err(&pdev->dev, "clock not found: %d\n", err);
>
> return err;
> }
>
> This calculates the error code only once and make the dev_err line short
> enough to not make it necessary to add a line break.
Sure that's better. Will send V2 soon
>
> Best regards
> Uwe
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-24 9:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 7:07 [PATCH 0/3] pwm: bcm2835: Minor fixes Stefan Wahren
2019-08-24 7:07 ` [PATCH 1/3] pwm: bcm2835: suppress error message for invalid period_ns Stefan Wahren
2019-08-24 9:26 ` Uwe Kleine-König
2019-08-24 7:07 ` [PATCH 2/3] pwm: bcm2835: fix period_ns range check Stefan Wahren
2019-08-24 9:26 ` Uwe Kleine-König
2019-08-24 7:07 ` [PATCH 3/3] pwm: bcm2835: suppress error message during deferred probe Stefan Wahren
2019-08-24 9:30 ` Uwe Kleine-König
2019-08-24 9:44 ` Stefan Wahren [this message]
2019-08-24 9:25 ` [PATCH 0/3] pwm: bcm2835: Minor fixes Uwe Kleine-König
2019-08-24 10:05 ` Stefan Wahren
2019-08-24 10:56 ` Uwe Kleine-König
2019-08-24 14:17 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141b0cb0-fa5c-ba3b-12cd-8e8252b1eb4e@gmx.net \
--to=wahrenst@gmx.net \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).