From: Stephen Boyd <swboyd@chromium.org>
To: Henry Chen <henryc.chen@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"JamesJJ Liao \(廖建智\)" <jamesjj.liao@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kees Cook <keescook@chromium.org>,
"Weiyi Lu \(呂威儀\)" <Weiyi.Lu@mediatek.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Fan Chen \(陳凡\)" <fan.chen@mediatek.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC RESEND PATCH 6/7] soc: mediatek: add MT8183 dvfsrc support
Date: Wed, 09 Jan 2019 16:38:41 -0800 [thread overview]
Message-ID: <154708072159.15366.10685577152949535083@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1546859353.6818.132.camel@mtksdaap41>
Quoting Henry Chen (2019-01-07 03:09:13)
> On Fri, 2019-01-04 at 07:08 +0800, Stephen Boyd wrote:
> > Quoting Henry Chen (2019-01-02 06:09:57)
> > > + val = dvfsrc_read(dvfsrc, DVFSRC_INT);
> > > + dvfsrc_write(dvfsrc, DVFSRC_INT_CLR, val);
> > > + dvfsrc_write(dvfsrc, DVFSRC_INT_CLR, 0x0);
> > > + if (val & DVFSRC_IRQ_TIMEOUT_EN)
> > > + dev_warn(dvfsrc->dev, "timeout at spm = %x", val);
> > > +
> >
> > Do you need to handle the irq at all? It looks like you are cleaning up
> > something and then complaining if there's a timeout, but otherwise
> > nothing goes on so perhaps the irq can just be ignored and nobody will
> > be the wiser?
>
> ok, it only for alarm system a timeout message.
Well if it's some timeout do you need to fail some dvfs operation if it
times out? Or take the whole system down in that scenario?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-10 0:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 14:09 [RFC RESEND PATCH 0/7] Add driver for dvfsrc and add support for active state of scpsys on mt8183 Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 1/7] dt-bindings: soc: Add DVFSRC driver bindings Henry Chen
2019-01-11 16:09 ` Rob Herring
2019-02-18 4:55 ` Henry Chen
2019-03-20 8:52 ` Nicolas Boichat
2019-01-02 14:09 ` [RFC RESEND PATCH 2/7] dt-bindings: soc: Add opp table on scpsys bindings Henry Chen
2019-01-03 18:45 ` Rob Herring
2019-01-07 11:04 ` Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 3/7] soc: mediatek: add support for the performance state Henry Chen
2019-01-03 22:57 ` Stephen Boyd
2019-01-07 11:06 ` Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 4/7] arm64: dts: mt8183: add performance state support of scpsys Henry Chen
2019-01-03 4:47 ` Viresh Kumar
2019-01-03 14:16 ` Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 5/7] soc: mediatek: add header for mediatek SIP interface Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 6/7] soc: mediatek: add MT8183 dvfsrc support Henry Chen
2019-01-03 23:08 ` Stephen Boyd
2019-01-07 11:09 ` Henry Chen
2019-01-10 0:38 ` Stephen Boyd [this message]
2019-01-02 14:09 ` [RFC RESEND PATCH 7/7] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2019-01-03 4:48 ` [RFC RESEND PATCH 0/7] Add driver for dvfsrc and add support for active state of scpsys on mt8183 Viresh Kumar
2019-01-03 14:31 ` Henry Chen
2019-01-03 22:53 ` Stephen Boyd
2019-01-07 11:04 ` Henry Chen
2019-01-07 16:34 ` Georgi Djakov
2019-01-09 3:08 ` Henry Chen
2019-01-10 9:39 ` Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154708072159.15366.10685577152949535083@swboyd.mtv.corp.google.com \
--to=swboyd@chromium.org \
--cc=Weiyi.Lu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fan.chen@mediatek.com \
--cc=henryc.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).