From: Mike Kravetz <mike.kravetz@oracle.com>
To: Qian Cai <cai@lca.pw>, Will Deacon <will@kernel.org>
Cc: linux-mm@kvack.org, Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: LTP hugemmap05 test case failure on arm64 with linux-next (next-20190613)
Date: Thu, 27 Jun 2019 11:09:16 -0700 [thread overview]
Message-ID: <15651f16-8d30-412f-8064-41ff03f3f47d@oracle.com> (raw)
In-Reply-To: <ed517a19-7804-c679-da94-279565001ca1@oracle.com>
On 6/24/19 2:53 PM, Mike Kravetz wrote:
> On 6/24/19 2:30 PM, Qian Cai wrote:
>> So the problem is that ipcget_public() has held the semaphore "ids->rwsem" for
>> too long seems unnecessarily and then goes to sleep sometimes due to direct
>> reclaim (other times LTP hugemmap05 [1] has hugetlb_file_setup() returns
>> -ENOMEM),
>
> Thanks for looking into this! I noticed that recent kernels could take a
> VERY long time trying to do high order allocations. In my case it was trying
> to do dynamic hugetlb page allocations as well [1]. But, IMO this is more
> of a general direct reclaim/compation issue than something hugetlb specific.
>
<snip>
>> Ideally, it seems only ipc_findkey() and newseg() in this path needs to hold the
>> semaphore to protect concurrency access, so it could just be converted to a
>> spinlock instead.
>
> I do not have enough experience with this ipc code to comment on your proposed
> change. But, I will look into it.
>
> [1] https://lkml.org/lkml/2019/4/23/2
I only took a quick look at the ipc code, but there does not appear to be
a quick/easy change to make. The issue is that shared memory creation could
take a long time. With issue [1] above unresolved, creation of hugetlb backed
shared memory segments could take a VERY long time.
I do not believe the test failure is arm specific. Most likely, it is just
because testing was done on a system with memory size to trigger this issue?
My plan is to focus on [1]. When that is resolved, this issue should go away.
--
Mike Kravetz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-27 18:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 21:34 LTP hugemmap05 test case failure on arm64 with linux-next (next-20190613) Qian Cai
2019-06-14 10:20 ` Will Deacon
2019-06-14 12:15 ` Qian Cai
2019-06-17 1:32 ` Anshuman Khandual
2019-06-17 1:41 ` Qian Cai
2019-06-24 9:35 ` Will Deacon
2019-06-24 12:58 ` Qian Cai
2019-06-24 21:30 ` Qian Cai
2019-06-24 21:53 ` Mike Kravetz
2019-06-27 18:09 ` Mike Kravetz [this message]
2019-06-27 18:54 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15651f16-8d30-412f-8064-41ff03f3f47d@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=anshuman.khandual@arm.com \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).