From: Jerry-ch Chen <Jerry-ch.Chen@mediatek.com>
To: Tomasz Figa <tfiga@chromium.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Sean Cheng (鄭昇弘)" <Sean.Cheng@mediatek.com>,
"laurent.pinchart+renesas@ideasonboard.com"
<laurent.pinchart+renesas@ideasonboard.com>,
"Rynn Wu (吳育恩)" <Rynn.Wu@mediatek.com>,
srv_heupstream <srv_heupstream@mediatek.com>,
"Po-Yang Huang (黃柏陽)" <po-yang.huang@mediatek.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"suleiman@chromium.org" <suleiman@chromium.org>,
"shik@chromium.org" <shik@chromium.org>,
"Jungo Lin (林明俊)" <jungo.lin@mediatek.com>,
"Sj Huang (黃信璋)" <sj.huang@mediatek.com>,
"yuzhao@chromium.org" <yuzhao@chromium.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"zwisler@chromium.org" <zwisler@chromium.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"Christie Yu (游雅惠)" <christie.yu@mediatek.com>,
"Frederic Chen (陳俊元)" <Frederic.Chen@mediatek.com>,
"hans.verkuil@cisco.com" <hans.verkuil@cisco.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver
Date: Tue, 3 Sep 2019 14:44:41 +0800 [thread overview]
Message-ID: <1567493081.18318.49.camel@mtksdccf07> (raw)
In-Reply-To: <CAAFQd5AGgeFbto6V1KkL0dp1QPziOKV3pWQDU2OJ+S1QKvnBdg@mail.gmail.com>
On Tue, 2019-09-03 at 13:19 +0800, Tomasz Figa wrote:
> On Mon, Sep 2, 2019 at 8:47 PM Jerry-ch Chen <Jerry-ch.Chen@mediatek.com> wrote:
> >
> > Hi Tomasz,
> >
> > On Fri, 2019-08-30 at 16:33 +0800, Tomasz Figa wrote:
> > > On Wed, Aug 28, 2019 at 11:00 AM Jerry-ch Chen
> > > <Jerry-ch.Chen@mediatek.com> wrote:
> > > >
> > > > Hi Tomasz,
> > > >
> > > > On Mon, 2019-08-26 at 14:36 +0800, Tomasz Figa wrote:
> > > > > Hi Jerry,
> > > > >
> > > > > On Sun, Aug 25, 2019 at 6:18 PM Jerry-ch Chen
> > > > > <Jerry-ch.Chen@mediatek.com> wrote:
> > > > > >
> > > > > > Hi Tomasz,
> > > > > >
> > > > > > On Fri, 2019-08-02 at 16:28 +0800, Tomasz Figa wrote:
> > > > > > > Hi Jerry,
> > > > > > >
> > > > > > > On Tue, Jul 09, 2019 at 04:41:12PM +0800, Jerry-ch Chen wrote:
> [snip]
> > > > static int mtk_fd_vb2_queue_setup(struct vb2_queue *vq,
> > > > unsigned int *num_buffers,
> > > > unsigned int *num_planes,
> > > > unsigned int sizes[],
> > > > struct device *alloc_devs[])
> > > > {
> > > > struct mtk_fd_ctx *ctx = vb2_get_drv_priv(vq);
> > > > struct device *dev = ctx->dev;
> > > > unsigned int size[2];
> > > >
> > > > switch (vq->type) {
> > > > case V4L2_BUF_TYPE_META_CAPTURE:
> > > > size[0] = ctx->dst_fmt.buffersize;
> > > > break;
> > > > case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
> > > > size[0] = ctx->src_fmt.plane_fmt[0].sizeimage;
> > > > if (*num_planes == 2)
> > > > size[1] = ctx->src_fmt.plane_fmt[1].sizeimage;
> > > > break;
> > > > }
> > > >
> > > > if (*num_planes == 1) {
> > > > if (sizes[0] < size[0])
> > > > return -EINVAL;
> > > > } else if (*num_planes == 2) {
> > > > if ((sizes[0] < size[0]) && (sizes[1] < size[1]))
> > > > return -EINVAL;
> > >
> > > Can we just use a loop here and combine the 2 cases above?
> > >
> > > Also, we need to fail with -EINVAL if *num_planes is > 2.
> > >
> > > > } else {
> > > > *num_planes = 1;
> > > > sizes[0] = size[0];
> > >
> > > This should be the case if *num_planes == 0 and the number of planes
> > > and sizes should match the currently active format.
> > >
> > I appreciate your comments,
> >
> > Ok, I will update as following:
> > static int mtk_fd_vb2_queue_setup(struct vb2_queue *vq,
> > unsigned int *num_buffers,
> > unsigned int *num_planes,
> > unsigned int sizes[],
> > struct device *alloc_devs[])
> > {
> > struct mtk_fd_ctx *ctx = vb2_get_drv_priv(vq);
> > unsigned int size[2];
> > unsigned int plane;
> >
> > switch (vq->type) {
> > case V4L2_BUF_TYPE_META_CAPTURE:
> > size[0] = ctx->dst_fmt.buffersize;
> > break;
> > case V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE:
> > size[0] = ctx->src_fmt.plane_fmt[0].sizeimage;
> > if (*num_planes == 2)
> > size[1] = ctx->src_fmt.plane_fmt[1].sizeimage;
> > break;
> > }
> >
> > if (*num_planes > 2)
> > return -EINVAL;
> > if (*num_planes == 0) {
> > if (vq->type == V4L2_BUF_TYPE_META_CAPTURE) {
> > sizes[0] = ctx->dst_fmt.buffersize;
> > *num_planes = 1;
> > return 0;
> > }
> >
> > *num_planes = ctx->src_fmt.num_planes;
> > for (plane = 0; plane < *num_planes; plane++)
> > sizes[plane] = ctx->src_fmt.plane_fmt[plane].sizeimage;
> > return 0;
> > }
> >
> > for (plane = 0; plane < *num_planes; plane++) {
> > if(sizes[plane] < size[plane])
> > return -EINVAL;
> > }
> > return 0;
> > }
> >
>
> Looks good, thanks!
>
> > > > }
> > > >
> > > > return 0;
> > > > }
> > > >
> > > > > [snip]
> > > > >
> > > > > > > > +static void mtk_fd_vb2_stop_streaming(struct vb2_queue *vq)
> > > > > > > > +{
> > > > > > > > + struct mtk_fd_ctx *ctx = vb2_get_drv_priv(vq);
> > > > > > > > + struct vb2_buffer *vb;
> > > > > > >
> > > > > > > How do we guarantee here that the hardware isn't still accessing the buffers
> > > > > > > removed below?
> > > > > > >
> > > > > > Maybe we can check the driver state flag and aborting the unfinished
> > > > > > jobs?
> > > > > > (fd_hw->state == FD_ENQ)
> > > > > >
> > > > >
> > > > > Yes, we need to either cancel or wait for the currently processing
> > > > > job. It depends on hardware capabilities, but cancelling is generally
> > > > > preferred for the lower latency.
> > > > >
> > > > Ok, it the state is ENQ, then we can disable the FD hw by controlling
> > > > the registers.
> > > >
> > > > for example:
> > > > writel(0x0, fd->fd_base + FD_HW_ENABLE);
> > > > writel(0x0, fd->fd_base + FD_INT_EN);
> > > >
> > >
> > > What's exactly the effect of writing 0 to FD_HW_ENABLE?
> > >
> > Sorry, my last reply didn't solve the question,
> > we should implement a mtk_fd_job_abort() for v4l2_m2m_ops().
> >
> > which is able to readl_poll_timeout_atomic()
> > and check the HW busy bits in the register FD_INT_EN;
> >
> > if they are not cleared until timeout, we could handle the last
> > processing job.
> > Otherwise, the FD irq handler should have handled the last processing
> > job and we could continue the stop_streaming().
> >
> > For job_abort():
> > static void mtk_fd_job_abort(void *priv)
> > {
> > struct mtk_fd_ctx *ctx = priv;
> > struct mtk_fd_dev *fd = ctx->fd_dev;
> > u32 val;
> > u32 ret;
> >
> > ret = readl_poll_timeout_atomic(fd->fd_base + MTK_FD_REG_OFFSET_INT_EN,
> > val,
> > (val & MTK_FD_HW_BUSY_MASK) ==
> > MTK_FD_HW_STATE_IS_BUSY,
> > USEC_PER_MSEC, MTK_FD_STOP_HW_TIMEOUT);
>
> Hmm, would it be possible to avoid the busy wait by having a
> completion that could be signalled from the interrupt handler?
>
> Best regards,
> Tomasz
I suppose that would be wakeup a wait queue in the interrupt handler,
the the wait_event_interrupt_timeout() will be used in here and system
suspend e.g. mtk_fd_suspend().
Or do you suggest to wait_event_interrupt_timeout() every frame in the
mtk_fd_ipi_handler()?
I think maybe the readl_poll_timeout_atomic would be good enough.
One more thing, for the mtk_fd_video_device_register()
Sorry that I would need to use intermediate variable here since the 80
columns check.
function = MEDIA_ENT_F_PROC_VIDEO_STATISTICS;
ret = v4l2_m2m_register_media_controller(m2m_dev, vfd, function);
if (ret) {
dev_err(dev, "Failed to init mem2mem media controller\n");
goto err_unreg_video;
}
Thanks and Best regards,
Jerry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-03 6:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 8:41 [RFC PATCH V2 0/4] media: platform: Add support for Face Detection (FD) on mt8183 SoC Jerry-ch Chen
2019-07-09 8:41 ` [RFC PATCH V2 1/4] dt-bindings: mt8183: Added FD dt-bindings Jerry-ch Chen
2019-07-12 7:16 ` CK Hu
2019-07-09 8:41 ` [RFC PATCH V2 2/4] dts: arm64: mt8183: Add FD nodes Jerry-ch Chen
2019-07-09 8:41 ` [RFC PATCH V2 3/4] media: platform: Add Mediatek FD driver KConfig Jerry-ch Chen
2019-09-05 12:30 ` Laurent Pinchart
2019-09-05 14:14 ` Jerry-ch Chen
2019-07-09 8:41 ` [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver Jerry-ch Chen
2019-07-09 10:56 ` Enrico Weigelt, metux IT consult
2019-07-29 6:01 ` Jerry-ch Chen
2019-07-29 9:57 ` Tomasz Figa
2019-07-29 11:58 ` Jerry-ch Chen
2019-08-09 8:07 ` Tomasz Figa
2019-09-05 12:35 ` Laurent Pinchart
2019-08-02 8:28 ` Tomasz Figa
2019-08-25 9:18 ` Jerry-ch Chen
2019-08-26 6:36 ` Tomasz Figa
2019-08-28 2:00 ` Jerry-ch Chen
2019-08-30 8:33 ` Tomasz Figa
2019-09-02 11:47 ` Jerry-ch Chen
2019-09-03 5:19 ` Tomasz Figa
2019-09-03 6:44 ` Jerry-ch Chen [this message]
2019-09-03 7:04 ` Tomasz Figa
2019-09-03 11:46 ` Jerry-ch Chen
2019-09-03 12:05 ` Tomasz Figa
2019-09-04 3:38 ` Jerry-ch Chen
2019-09-04 4:15 ` Tomasz Figa
2019-09-04 6:09 ` Jerry-ch Chen
2019-09-04 6:34 ` Tomasz Figa
2019-09-04 8:09 ` Jerry-ch Chen
2019-09-04 8:25 ` Tomasz Figa
2019-09-04 9:01 ` Jerry-ch Chen
2019-09-04 9:03 ` Tomasz Figa
2019-09-04 9:26 ` Jerry-ch Chen
2019-09-04 13:12 ` Tomasz Figa
2019-09-04 13:19 ` Jerry-ch Chen
2019-09-05 7:02 ` Jerry-ch Chen
2019-09-05 7:13 ` Tomasz Figa
2019-09-05 8:16 ` Jerry-ch Chen
2019-09-05 8:52 ` Tomasz Figa
2019-09-05 13:36 ` Jerry-ch Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567493081.18318.49.camel@mtksdccf07 \
--to=jerry-ch.chen@mediatek.com \
--cc=Frederic.Chen@mediatek.com \
--cc=Rynn.Wu@mediatek.com \
--cc=Sean.Cheng@mediatek.com \
--cc=christie.yu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=jungo.lin@mediatek.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=po-yang.huang@mediatek.com \
--cc=shik@chromium.org \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=suleiman@chromium.org \
--cc=tfiga@chromium.org \
--cc=yuzhao@chromium.org \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).