From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA27DC433ED for ; Thu, 8 Apr 2021 12:59:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73E706008E for ; Thu, 8 Apr 2021 12:59:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73E706008E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L4CZtJvVhx5JBeXM3B1S2whHGshWVdgl78AXwopr/2M=; b=iIPv7RGxfzcgsDHY4rcBfd5nm h92FeNEKtFRxf/tPZJo66JOalIEUjGNx/X1vbQ4XkpVX+g9GbDHC1AXyYLH3GM3XbA807ilv1+Drv Yik1NHZcV2pPTDPYsGp2KyQHQX8GsB0NQYq9NgN4Y0/r9HZb+xoOeexB0TiBzPDPhCXAqEm9hSd7g 5GC2s6pN0QkUTozVcRCfBIx2olN9tc7Hd/Utt5DoZytuzU9bI0ZETcq28JyZGKz1jd8O6Nw0uZcu3 KzsbBsqFWoAYbtBZSd1jGDXuO3k1JqT574dALS/YTTJ0+exfo6/I2JTBijAsljqVa4TRY2SSr+hpH yAE8Hx/hw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUUED-0083kq-Qy; Thu, 08 Apr 2021 12:57:45 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUUE8-0083jX-H8 for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 12:57:43 +0000 Received: from fraeml712-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4FGLhh6ZXVz67vP6; Thu, 8 Apr 2021 20:50:28 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml712-chm.china.huawei.com (10.206.15.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 8 Apr 2021 14:57:31 +0200 Received: from [10.47.1.29] (10.47.1.29) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 8 Apr 2021 13:57:30 +0100 Subject: Re: [PATCH 1/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU To: Jonathan Cameron , Will Deacon CC: "liuqi (BA)" , "mark.rutland@arm.com" , Zhangshaokun , Linuxarm , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <1617788943-52722-1-git-send-email-liuqi115@huawei.com> <1617788943-52722-2-git-send-email-liuqi115@huawei.com> <20210407204004.GB16011@willie-the-truck> <20210408100157.000062f0@Huawei.com> From: John Garry Message-ID: <16a7a3f8-82b5-a113-57c0-a9d575c649bd@huawei.com> Date: Thu, 8 Apr 2021 13:55:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <20210408100157.000062f0@Huawei.com> Content-Language: en-US X-Originating-IP: [10.47.1.29] X-ClientProxiedBy: lhreml716-chm.china.huawei.com (10.201.108.67) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_135741_863061_AB3DB0C5 X-CRM114-Status: GOOD ( 12.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/04/2021 10:01, Jonathan Cameron wrote: > On Wed, 7 Apr 2021 21:40:05 +0100 > Will Deacon wrote: > >> On Wed, Apr 07, 2021 at 05:49:02PM +0800, Qi Liu wrote: >>> PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported >>> to sample bandwidth, latency, buffer occupation etc. >>> >>> Each PMU RCiEP device monitors multiple root ports, and each RCiEP is >>> registered as a pmu in /sys/bus/event_source/devices, so users can >>> select target PMU, and use filter to do further sets. >>> >>> Filtering options contains: >>> event - select the event. >>> subevent - select the subevent. >>> port - select target root ports. Information of root ports >>> are shown under sysfs. >>> bdf - select requester_id of target EP device. >>> trig_len - set trigger condition for starting event statistics. >>> trigger_mode - set trigger mode. 0 means starting to statistic when >>> bigger than trigger condition, and 1 means smaller. >>> thr_len - set threshold for statistics. >>> thr_mode - set threshold mode. 0 means count when bigger than >>> threshold, and 1 means smaller. >>> >>> Reviewed-by: Jonathan Cameron >> >> Do you have a link to this review, please? > > Internal review, so drop the tag. > > Jonathan Hi Will, Are you implying that you would rather that any review for these drivers is done in public on the lists? Cheers, John _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel