From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: at91sam9261ek: remove unused chosen nodes
Date: Wed, 22 May 2019 10:19:29 +0200 [thread overview]
Message-ID: <1aa65857-7638-b78f-8cde-cc5c968555cc@linaro.org> (raw)
In-Reply-To: <2f831f1b-c87d-48bd-cf02-2ebb334b964c@linaro.org>
Hi Rob,
a gentle ping ... ;)
On 08/04/2019 18:30, Daniel Lezcano wrote:
>
> Hi Rob,
>
> the following patch has been pushed in 2016 by commit 51f0aeb2d21f1.
>
> Being able to specify which timer should act as a clocksource or a
> clockevent is often requested. Doing this from the driver itself forces
> to do some assumption in the timer definition ordering in the DT.
>
> That impacts badly the resulting code and its self-encapsulation.
>
> - There is one node and the driver hardcodes the value and initializes
> a clocksource and a clockevent
>
> - There are several nodes, one for the clocksource and one for the
> clockevent, and the driver assumes the order of the node in the DT
>
> - There are several nodes and multiple channels and those are used for
> PWM. It is impossible to know which one are used for PWM or for the
> clocksource or for the clockevent
>
> For example with STM32, we should be able to specify which timer to use.
> There are 16 timers IIRC, they can be used for PWM, clocksource or
> clockevent. Half is 16 bits, other half is 32 bits, depending on the
> destination of the platform we can be interested to use one or another
> without recompiling a kernel but just the DT.
>
> We need a way to specify which timer to be used from the DT. The patch
> below sounded like a good way to characterize the nodes as they belong
> to the 'chosen' node and we stay to a 'linux' thing.
>
> What do you think ?
>
>
> On 08/04/2019 17:11, Alexandre Belloni wrote:
>> The chosen clocksource and clockevent bindings have never been accepted and
>> parsed, remove them.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
>> ---
>> arch/arm/boot/dts/at91sam9261ek.dts | 8 --------
>> 1 file changed, 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9261ek.dts b/arch/arm/boot/dts/at91sam9261ek.dts
>> index a57f2d435dca..11ed55d8a87d 100644
>> --- a/arch/arm/boot/dts/at91sam9261ek.dts
>> +++ b/arch/arm/boot/dts/at91sam9261ek.dts
>> @@ -15,14 +15,6 @@
>> chosen {
>> bootargs = "rootfstype=ubifs ubi.mtd=5 root=ubi0:rootfs rw";
>> stdout-path = "serial0:115200n8";
>> -
>> - clocksource {
>> - timer = <&timer0>;
>> - };
>> -
>> - clockevent {
>> - timer = <&timer1>;
>> - };
>> };
>>
>> memory {
>>
>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-22 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 15:11 [PATCH] ARM: dts: at91sam9261ek: remove unused chosen nodes Alexandre Belloni
2019-04-08 16:30 ` Daniel Lezcano
2019-04-28 12:47 ` Daniel Lezcano
2019-05-22 8:19 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1aa65857-7638-b78f-8cde-cc5c968555cc@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).