From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 03/11] clocksource: sp804: add device tree support
Date: Wed, 13 Mar 2013 16:35:02 +0000 [thread overview]
Message-ID: <201303131635.02355.arnd@arndb.de> (raw)
In-Reply-To: <1363189748.3100.108.camel@hornet>
On Wednesday 13 March 2013, Pawel Moll wrote:
> Fine, so simply reverse the logic and drop the "arm,sp804-clock*"
> properties. Something like:
>
> if (has_timint1) {
> evtoffs = TIMER_1_BASE;
> irq = irq_of_parse_and_map(np, 1);
> srcoffs = TIMER_2_BASE;
> } else (has_timint2) {
> evtoffs = TIMER_2_BASE;
> irq = irq_of_parse_and_map(np, 2);
> srcoffs = TIMER_1_BASE;
> } else {
> can't be clockevent, sorry
> }
>
> Hope it makes clear what I'd expect from the driver.
Makes sense. I guess you can actually derive "has_timint1"
from the presence of the irq and just try to parse it:
irq = irq_of_parse_and_map(np, 0);
if (irq) {
evtoffs = TIMER_1_BASE;
srcoffs = TIMER_2_BASE;
} else {
irq = irq_of_parse_and_map(np, 1);
if (!irq)
return -ENODEV;
srcoffs = TIMER_1_BASE;
evtoffs = TIMER_2_BASE;
}
I wonder if we can ever get into the second case though: If the
first interrupt in not valid, can there be a second one in the
interrupts property? I don't know of a way to put an "invalid"
interrupt in there.
Arnd
next prev parent reply other threads:[~2013-03-13 16:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 5:05 [PATCH v3 00/11] add hisilicon SoC support Haojian Zhuang
2013-03-13 5:05 ` [PATCH v3 01/11] clocksource: move sp timer driver Haojian Zhuang
2013-03-13 5:05 ` [PATCH v3 02/11] clocksource: select USE_OF by default Haojian Zhuang
2013-03-13 5:05 ` [PATCH v3 03/11] clocksource: sp804: add device tree support Haojian Zhuang
2013-03-13 11:05 ` Pawel Moll
2013-03-13 11:37 ` Haojian Zhuang
2013-03-13 11:41 ` Pawel Moll
2013-03-13 14:17 ` Rob Herring
2013-03-13 14:42 ` Pawel Moll
2013-03-13 14:51 ` Rob Herring
2013-03-13 14:55 ` Pawel Moll
2013-03-13 15:11 ` Haojian Zhuang
2013-03-13 15:23 ` Pawel Moll
2013-03-13 15:25 ` Haojian Zhuang
2013-03-13 15:29 ` Pawel Moll
2013-03-13 15:39 ` Rob Herring
2013-03-13 15:41 ` Pawel Moll
2013-03-13 15:44 ` Haojian Zhuang
2013-03-13 15:42 ` Haojian Zhuang
2013-03-13 15:49 ` Pawel Moll
2013-03-13 16:35 ` Arnd Bergmann [this message]
2013-03-13 16:41 ` Pawel Moll
2013-03-15 12:20 ` Russell King - ARM Linux
2013-03-13 5:05 ` [PATCH v3 04/11] ARM: integrator: use clocksource_of_init for sp804 Haojian Zhuang
2013-03-13 5:05 ` [PATCH v3 05/11] ARM: highbank: " Haojian Zhuang
2013-03-13 5:05 ` [PATCH v3 06/11] ARM: vexpress: " Haojian Zhuang
2013-03-13 11:10 ` Pawel Moll
2013-03-13 11:42 ` Haojian Zhuang
2013-03-13 11:46 ` Pawel Moll
2013-03-13 12:21 ` Haojian Zhuang
2013-03-13 14:48 ` Pawel Moll
2013-03-13 15:01 ` Haojian Zhuang
2013-03-13 15:19 ` Pawel Moll
2013-03-13 15:59 ` Haojian Zhuang
2013-03-13 16:28 ` Pawel Moll
2013-03-13 16:32 ` Rob Herring
2013-03-15 12:34 ` Russell King - ARM Linux
2013-03-15 12:58 ` Pawel Moll
2013-03-15 18:10 ` Russell King - ARM Linux
2013-03-13 5:05 ` [PATCH v3 07/11] ARM: debug: support debug ll on hisilicon soc Haojian Zhuang
2013-03-13 5:05 ` [PATCH v3 08/11] clk: hi3xxx: add clock support Haojian Zhuang
2013-03-13 5:05 ` [PATCH v3 09/11] ARM: hi3xxx: add board support with device tree Haojian Zhuang
2013-03-13 5:05 ` [PATCH v3 10/11] ARM: hi3xxx: enable hi4511 " Haojian Zhuang
2013-03-13 5:05 ` [PATCH v3 11/11] ARM: config: append arch hi3xxx into multi defconfig Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303131635.02355.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).