From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ethernet: Add new driver for Marvell Armada 375 network unit
Date: Tue, 8 Jul 2014 20:40:24 -0300 [thread overview]
Message-ID: <20140708234024.GA28830@arch.cereza> (raw)
In-Reply-To: <20140708.152655.619472955292197550.davem@davemloft.net>
On 08 Jul 03:26 PM, David Miller wrote:
> From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> Date: Sat, 5 Jul 2014 08:54:46 -0300
>
> > +module_param(rxq_number, int, S_IRUGO);
> > +module_param(txq_number, int, S_IRUGO);
>
> Please don't use module parameters (undocumented ones at that) for things
> like this.
>
> Instead, use or create standard interfaces which other drivers can use as
> well, so that the user interface is consistent for setting things of this
> nature regardless of device type.
>
Hm... in fact these two parameters should be removed. They are redundant in
this and the mvneta driver. The Rx queue number should be fixed and none of
the drivers support more than 1.
The Tx queue number should be set to the hardware supported one, there's no
reason to use something different.
So, unless someone objects, we'll remove them in v4.
Thanks for the feedback,
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
prev parent reply other threads:[~2014-07-08 23:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 11:54 [PATCH v2 net-next 0/3] Network driver for Armada 375 SoC Ezequiel Garcia
2014-07-05 11:54 ` [PATCH v2 2/3] ARM: mvebu: Add support for the network controller in " Ezequiel Garcia
2014-07-05 11:54 ` [PATCH v2 3/3] ARM: mvebu: Enable the network controller in Armada 375 DB board Ezequiel Garcia
[not found] ` <1404561288-11720-2-git-send-email-ezequiel.garcia@free-electrons.com>
2014-07-08 22:26 ` [PATCH v2 1/3] ethernet: Add new driver for Marvell Armada 375 network unit David Miller
2014-07-08 23:40 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140708234024.GA28830@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).