From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC
Date: Wed, 30 Jul 2014 16:46:26 +0100 [thread overview]
Message-ID: <20140730154626.GD20162@leverpostej> (raw)
In-Reply-To: <1406732794-20920-3-git-send-email-rric@kernel.org>
Hi,
On Wed, Jul 30, 2014 at 04:06:31PM +0100, Robert Richter wrote:
> From: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
>
> Add initial device tree nodes for Cavium Thunder SoCs with support of
> 48 cores and gicv3. The dts file requires further changes, esp. for
> pci, gicv3-its and smmu. This changes will be added later together
> with the device drivers.
>
> Signed-off-by: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
> Signed-off-by: Robert Richter <rrichter@cavium.com>
> ---
> arch/arm64/boot/dts/Makefile | 1 +
> arch/arm64/boot/dts/thunder-88xx.dts | 387 +++++++++++++++++++++++++++++++++++
> 2 files changed, 388 insertions(+)
> create mode 100644 arch/arm64/boot/dts/thunder-88xx.dts
>
> diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile
> index c52bdb051f66..f8001a62029c 100644
> --- a/arch/arm64/boot/dts/Makefile
> +++ b/arch/arm64/boot/dts/Makefile
> @@ -1,3 +1,4 @@
> +dtb-$(CONFIG_ARCH_THUNDER) += thunder-88xx.dtb
> dtb-$(CONFIG_ARCH_VEXPRESS) += rtsm_ve-aemv8a.dtb foundation-v8.dtb
> dtb-$(CONFIG_ARCH_XGENE) += apm-mustang.dtb
>
> diff --git a/arch/arm64/boot/dts/thunder-88xx.dts b/arch/arm64/boot/dts/thunder-88xx.dts
> new file mode 100644
> index 000000000000..4cf20ac9138b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/thunder-88xx.dts
> @@ -0,0 +1,387 @@
> +/*
> + * Cavium Thunder DTS file
> + *
> + * Copyright (C) 2013, Cavium Inc.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + */
> +/dts-v1/;
> +
> +/* Reserving first 12MB of DDR for firmware */
> +/memreserve/ 0x00000000 0x00c00000;
What exactly is this memreserve intended to protect at runtime?
The only item of runtime firmware I see in use below is PSCI on the
secure side.
How is the kernel booted on this platform? UEFI?
> +/ {
> + model = "Cavium ThunderX CN88XX Family";
> + compatible = "cavium,thunder-88xx";
Please don't use wildcards in compatible strings. Give this an absolute
name, and override as necessary.
> + interrupt-parent = <&gic0>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + aliases {
> + serial0 = &uaa0;
> + serial1 = &uaa1;
> + };
> +
> + psci {
> + compatible = "arm,psci-0.2";
> + method = "smc";
> + };
Nice!
> +
> + cpus {
> + #address-cells = <2>;
> + #size-cells = <0>;
> +
> + cpu at 000 {
> + device_type = "cpu";
> + compatible = "cavium,thunder", "arm,armv8";
> + reg = <0x0 0x000>;
> + enable-method = "psci";
> + };
Just to check: both the SoC and CPU are called thunder?
[...]
> +
> + memory at 00000000 {
> + device_type = "memory";
> + reg = <0x0 0x00000000 0x0 0x80000000>;
> + };
> +
> + gic0: interrupt-controller at 801000000000 {
To make this easier to read, please place a comma between 32-bit
portions of the unit address (e.g. here have 8010,00000000).
> + compatible = "arm,gic-v3";
> + #interrupt-cells = <3>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
This has no children, so why have ranges, #address-cells, and
#size-cells?
> + interrupt-controller;
> + reg = <0x8010 0x00000000 0x0 0x010000>, /* GICD */
> + <0x8010 0x80000000 0x0 0x200000>; /* GICR */
> + interrupts = <1 9 0xf04>;
> + };
> +
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <1 13 0xff01>,
> + <1 14 0xff01>,
> + <1 11 0xff01>,
> + <1 10 0xff01>;
> + };
> +
> + soc {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + clocks {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + refclk50mhz: refclk50mhz {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <50000000>;
> + clock-output-names = "refclk50mhz";
> + };
> + };
Please get rid of the clocks node and just put the clocks here.
> +
> + uaa0: serial at 87e024000000 {
> + compatible = "arm,pl011", "arm,primecell";
> + reg = <0x87e0 0x24000000 0x0 0x1000>;
> + interrupts = <1 21 4>;
> + clocks = <&refclk50mhz>;
> + clock-names = "apb_pclk";
Is this actually the apb_pclk, or is the the uartclk? I assume it's the
latter.
> + };
> +
> + uaa1: serial at 87e025000000 {
> + compatible = "arm,pl011", "arm,primecell";
> + reg = <0x87e0 0x25000000 0x0 0x1000>;
> + interrupts = <1 22 4>;
> + clocks = <&refclk50mhz>;
> + clock-names = "apb_pclk";
Similarly?
Thanks,
Mark.
next prev parent reply other threads:[~2014-07-30 15:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 15:06 [PATCH 0/5] arm64, thunder: Enable Cavium Thunder SoC Family Robert Richter
2014-07-30 15:06 ` [PATCH 1/5] arm64, thunder: Add Kconfig option for " Robert Richter
2014-07-30 15:06 ` [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC Robert Richter
2014-07-30 15:46 ` Mark Rutland [this message]
2014-07-30 16:37 ` Rob Herring
2014-07-30 17:48 ` Mark Rutland
2014-08-05 8:47 ` Robert Richter
2014-07-31 11:32 ` Robert Richter
2014-07-31 12:34 ` Robert Richter
2014-07-31 15:22 ` Rob Herring
2014-07-31 16:35 ` Robert Richter
[not found] ` <CAFpQJXWKybVUxpHg8MVrVMjLj3swuxLGo_9r1tL+gZ4hxUHTzQ@mail.gmail.com>
2014-07-31 9:53 ` Mark Rutland
[not found] ` <CAFpQJXUtP=v7FSLd3_OU7FG3w=pKYy2ihTQULA_DPEacsSu0Og@mail.gmail.com>
2014-07-31 11:33 ` Mark Rutland
2014-08-01 17:04 ` Robert Richter
2014-08-01 18:00 ` Mark Rutland
2014-08-01 10:25 ` Robert Richter
2014-07-30 18:12 ` Olof Johansson
2014-07-30 18:35 ` Mark Rutland
2014-07-30 18:14 ` Olof Johansson
2014-08-01 16:18 ` Robert Richter
2014-08-28 16:15 ` Robert Richter
2014-08-28 16:25 ` Mark Rutland
2014-08-28 16:31 ` Olof Johansson
2014-08-28 18:14 ` Robert Richter
2014-08-28 23:01 ` Olof Johansson
2014-08-29 12:10 ` Robert Richter
2014-08-29 13:49 ` [PATCH] arm64, dts: Add dtbs_install make target Robert Richter
2014-09-05 6:55 ` Robert Richter
2014-07-31 10:24 ` [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder SoC Arnd Bergmann
2014-07-31 11:33 ` Robert Richter
2014-07-30 15:06 ` [PATCH 3/5] arm64, thunder: document devicetree bindings " Robert Richter
2014-07-30 15:06 ` [PATCH 4/5] arm64, defconfig: Enable Cavium Thunder SoC in defconfig Robert Richter
2014-07-30 15:06 ` [PATCH 5/5] arm64, defconfig: Enable tmpfs mount option Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140730154626.GD20162@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).