From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: dts: sun8i: Extend Orange Pi PC dt to also handle the PC Plus
Date: Mon, 25 Jul 2016 08:40:33 +0200 [thread overview]
Message-ID: <20160725064033.GA7419@lukather> (raw)
In-Reply-To: <bce2b340-a930-8771-4560-dc61bf5828d5@redhat.com>
Hi,
On Wed, Jul 13, 2016 at 12:01:41PM +0200, Hans de Goede wrote:
> Hi,
>
> On 13-07-16 10:45, Maxime Ripard wrote:
> >On Sat, Jul 09, 2016 at 10:21:55PM +0200, Hans de Goede wrote:
> >>There is a new Orange Pi PC Plus available now, rather then adding
> >>yet another dts file for this variant, extend the existing
> >>Orange Pi PC to support the sdio wifi and emmc found on this variant.
> >>
> >>Downside of this approach is the following messages in dmesg when run
> >>on the non Plus Orange Pi PC:
> >>
> >>sunxi-mmc 1c10000.mmc: fatal err update clk timeout
> >>sunxi-mmc 1c11000.mmc: smc 2 err, cmd 8, RTO !!
> >>sunxi-mmc 1c11000.mmc: smc 2 err, cmd 55, RTO !!
> >>sunxi-mmc 1c11000.mmc: smc 2 err, cmd 55, RTO !!
> >>sunxi-mmc 1c11000.mmc: smc 2 err, cmd 55, RTO !!
> >>sunxi-mmc 1c11000.mmc: smc 2 err, cmd 55, RTO !!
> >>sunxi-mmc 1c11000.mmc: smc 2 err, cmd 1, RTO !!
> >>
> >>Note these are completely harmless and there is no adverse effect
> >>to the functioning of the non Plus Orange Pi PC.
> >>
> >>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >>---
> >> arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts | 40 +++++++++++++++++++++++++++++-
> >> 1 file changed, 39 insertions(+), 1 deletion(-)
> >>
> >>diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
> >>index b8340f7..f9bf260 100644
> >>--- a/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
> >>+++ b/arch/arm/boot/dts/sun8i-h3-orangepi-pc.dts
> >>@@ -49,11 +49,13 @@
> >> #include <dt-bindings/pinctrl/sun4i-a10.h>
> >>
> >> / {
> >>- model = "Xunlong Orange Pi PC";
> >>+ model = "Xunlong Orange Pi PC / PC Plus";
> >> compatible = "xunlong,orangepi-pc", "allwinner,sun8i-h3";
> >>
> >> aliases {
> >> serial0 = &uart0;
> >>+ /* ethernet0 is the H3 emac, defined in sun8i-h3.dtsi */
> >>+ ethernet1 = &rtl8189ftv;
> >> };
> >>
> >> chosen {
> >>@@ -118,6 +120,42 @@
> >> status = "okay";
> >> };
> >>
> >>+/* Note only present on orangepi pc *plus* */
> >>+&mmc1 {
> >>+ pinctrl-names = "default";
> >>+ pinctrl-0 = <&mmc1_pins_a>;
> >>+ vmmc-supply = <®_vcc3v3>;
> >>+ bus-width = <4>;
> >>+ non-removable;
> >>+ status = "okay";
> >>+
> >>+ /*
> >>+ * Explicitly define the sdio device, so that we can add an ethernet
> >>+ * alias for it (which e.g. makes u-boot set a mac-address).
> >>+ */
> >>+ rtl8189ftv: sdio_wifi at 1 {
> >>+ reg = <1>;
> >>+ };
> >>+};
> >
> >Nothing prevents you from including the orange pi pc dts, from the
> >orange pi plus dts.
> >
> >It prevents the duplication you were trying to avoid, and it doesn't
> >create all those spurious errors and devices.
>
> That would solve the copy paste problem on the kernel side, but that
> would still mean adding a new u-boot defconfig for this, which means that
> all the distro's which ship with prebuild u-boot binaries need to build
> for yet another board, something which I would like to avoid.
Still, registering devices that are not present on the board is not an
option.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160725/b9319e9a/attachment.sig>
next prev parent reply other threads:[~2016-07-25 6:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 20:21 [PATCH 1/4] ARM: dts: sun8i: Extend Orange Pi PC dt to also handle the PC Plus Hans de Goede
2016-07-09 20:21 ` [PATCH 2/4] ARM: dts: sun8i: Extend Orange Pi Plus dt to also handle the Plus 2E Hans de Goede
2016-07-09 20:21 ` [PATCH 3/4] ARM: dts: sun8i: Add ethernet1 alias to Orange Pi 2 dts Hans de Goede
2016-07-28 18:20 ` Maxime Ripard
2016-07-09 20:21 ` [PATCH 4/4] ARM: dts: sun8i: Add dts file for the Orange Pi Lite SBC Hans de Goede
2016-07-28 18:21 ` Maxime Ripard
2016-07-13 8:45 ` [PATCH 1/4] ARM: dts: sun8i: Extend Orange Pi PC dt to also handle the PC Plus Maxime Ripard
2016-07-13 10:01 ` Hans de Goede
2016-07-25 6:40 ` Maxime Ripard [this message]
2016-07-26 21:00 ` Hans de Goede
2016-07-26 21:07 ` Hans de Goede
2016-07-28 18:17 ` Maxime Ripard
2016-07-28 20:36 ` Hans de Goede
2016-08-07 14:25 ` Hans de Goede
2016-08-26 18:45 ` Hans de Goede
2016-08-31 16:28 ` Maxime Ripard
2016-09-03 11:05 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725064033.GA7419@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).