From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Yong Deng <yong.deng@magewell.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 0/6] media: sun6i: Separate H3 compatible from A31
Date: Fri, 30 Nov 2018 09:47:08 +0100 [thread overview]
Message-ID: <20181130084708.rbggq5y3f2c5w7vu@flea> (raw)
In-Reply-To: <20181130075849.16941-1-wens@csie.org>
[-- Attachment #1.1: Type: text/plain, Size: 1331 bytes --]
On Fri, Nov 30, 2018 at 03:58:43PM +0800, Chen-Yu Tsai wrote:
> The CSI (camera sensor interface) controller found on the H3 (and H5)
> is a reduced version of the one found on the A31. It only has 1 channel,
> instead of 4 channels supporting time-multiplexed BT.656 on the A31.
> Since the H3 is a reduced version, it cannot "fallback" to a compatible
> that implements more features than it supports.
>
> This series separates support for the H3 variant from the A31 variant.
>
> Patches 1 ~ 3 separate H3 CSI from A31 CSI in the bindings, driver, and
> device tree, respectively.
>
> Patch 4 adds a pinmux setting for the MCLK (master clock). Some camera
> sensors use the master clock from the SoC instead of a standalone
> crystal.
>
> Patches 5 and 6 are examples of using a camera sensor with an SBC.
> Since the modules are detachable, these changes should not be merged.
> They should be implemented as overlays instead.
>
> Please have a look.
>
> In addition, I found that the first frame captured seems to always be
> incomplete, with either parts cropped, out of position, or missing
> color components.
For the first 4 patches,
Acked-by: Maxime Ripard <maxime.ripard@bootlin.com>
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-11-30 8:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 7:58 [PATCH 0/6] media: sun6i: Separate H3 compatible from A31 Chen-Yu Tsai
2018-11-30 7:58 ` [PATCH 1/6] media: dt-bindings: " Chen-Yu Tsai
2018-12-03 9:41 ` Jagan Teki
2018-12-03 9:48 ` Chen-Yu Tsai
2018-12-04 13:13 ` sakari.ailus
2018-12-12 2:33 ` Rob Herring
2018-11-30 7:58 ` [PATCH 2/6] media: sun6i: Add H3 compatible Chen-Yu Tsai
2018-12-03 9:42 ` Jagan Teki
2018-11-30 7:58 ` [PATCH 3/6] ARM: dts: sunxi: h3/h5: Drop A31 fallback compatible for CSI controller Chen-Yu Tsai
2018-12-03 9:44 ` Jagan Teki
2019-01-24 10:15 ` Chen-Yu Tsai
2018-11-30 7:58 ` [PATCH 4/6] ARM: dts: sunxi: h3-h5: Add pinmux setting for CSI MCLK on PE1 Chen-Yu Tsai
2018-12-03 9:45 ` Jagan Teki
2019-01-24 10:16 ` Chen-Yu Tsai
2018-11-30 7:58 ` [PATCH 5/6] [DO NOT MERGE] ARM: dts: sunxi: bananapi-m2p: Add HDF5640 camera module Chen-Yu Tsai
2018-12-03 9:51 ` Jagan Teki
2018-12-03 9:54 ` Chen-Yu Tsai
2018-11-30 7:58 ` [PATCH 6/6] [DO NOT MERGE] ARM: dts: sunxi: libretech-all-h3-cc: " Chen-Yu Tsai
2018-11-30 8:47 ` Maxime Ripard [this message]
2018-12-13 22:10 ` [PATCH 0/6] media: sun6i: Separate H3 compatible from A31 sakari.ailus
2018-12-14 2:23 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130084708.rbggq5y3f2c5w7vu@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).