On Tue, Dec 11, 2018 at 03:15:35PM -0700, Nathan Chancellor wrote:
> On Tue, Dec 11, 2018 at 10:06:20PM +0000, Mark Brown wrote:

> > in ddbridge-ci.c and some other media files.  This is because
> > ddbridge.h includes asm/irq.h but that does not directly include headers
> > which define the above types and it appears some header changes have
> > removed an implicit inclusion of those.  Moving the asm includes after
> > the linux ones in ddbridge.h fixes this though this appears to be
> > against the coding style for media.

> I sent a patch for this yesterday, I think moving the asm includes after
> the linux ones is the correct fix according to the rest of the kernel:
> https://lore.kernel.org/linux-media/20181210233514.3069-1-natechancellor@gmail.com/

> Hopefully it can be picked up quickly.

Ah, great - thanks.  I agree this is probably the best fix, I just
wasn't sure if the media people had some other idea given the coding
style there.