From: Rob Herring <robh@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
Roy Pledge <roy.pledge@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Leo Li <leoyang.li@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] Documentation: DT: Add entry for DPAA2 console
Date: Thu, 3 Jan 2019 14:32:50 -0600 [thread overview]
Message-ID: <20190103203250.GA18731@bogus> (raw)
In-Reply-To: <1545406240-3061-3-git-send-email-ioana.ciornei@nxp.com>
On Fri, Dec 21, 2018 at 03:31:11PM +0000, Ioana Ciornei wrote:
> This patch adds a devicetree binding documentation for
> FSL's DPAA2 console.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
> Documentation/devicetree/bindings/misc/dpaa2-console.txt | 11 +++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/dpaa2-console.txt
>
> diff --git a/Documentation/devicetree/bindings/misc/dpaa2-console.txt b/Documentation/devicetree/bindings/misc/dpaa2-console.txt
> new file mode 100644
> index 0000000..f4e16b1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/dpaa2-console.txt
> @@ -0,0 +1,11 @@
> +DPAA2 console support
> +
> +Required properties:
> +
> + - compatible
> + Value type: <string>
> + Definition: Must be "dpaa2-console".
> + - reg
> + Value type: <prop-encoded-array>
> + Definition: A standard property. Specifies the region where the MCFBA
> + (MC firmware base address) register can be found.
What's the relationship between MCFBA and the console? The binding
should describe the h/w block or firmware interface not the feature you
want to implement. Are there other functions provided by the MC
firmware?
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-03 20:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 15:31 [PATCH 0/3] soc: fsl: add DPAA2 log console support Ioana Ciornei
2018-12-21 15:31 ` [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 platforms Ioana Ciornei
2019-01-12 2:47 ` Shawn Guo
2019-01-16 10:02 ` Ioana Ciornei
2019-01-16 10:56 ` Shawn Guo
2019-01-16 10:59 ` Ioana Ciornei
2019-01-16 17:31 ` Ioana Ciornei
2019-01-22 2:53 ` Shawn Guo
2018-12-21 15:31 ` [PATCH 2/3] Documentation: DT: Add entry for DPAA2 console Ioana Ciornei
2019-01-03 20:32 ` Rob Herring [this message]
2019-01-04 17:50 ` Ioana Ciornei
2019-01-22 2:54 ` Shawn Guo
2018-12-21 15:31 ` [PATCH 3/3] soc: fsl: add DPAA2 console support Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190103203250.GA18731@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ioana.ciornei@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roy.pledge@nxp.com \
--cc=ruxandra.radulescu@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).