From: Anand Moon <linux.amoon@gmail.com>
To: linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org
Cc: Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: [RFCv1 2/3] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy
Date: Wed, 23 Jan 2019 15:12:08 +0000 [thread overview]
Message-ID: <20190123151209.2080-3-linux.amoon@gmail.com> (raw)
In-Reply-To: <20190123151209.2080-1-linux.amoon@gmail.com>
This patch enables the USB Host controller (USB0) and the relative USB0 PHY.
From the shematics GPIOAO.BIT5 gpio input for the PWREN signal of the
USB_OTG controller (usb0) which is also linked to USB_HOST controller (usb1).
Add missing phy-supply link to both USB0 and USB1 phy controller
This changes fixed the power issue on usb ports. Changes help fix usb reset warning.
[ 821.991470] usb 1-1.2: reset high-speed USB device number 3 using dwc2
[ 825.243385] usb 1-1.2: reset high-speed USB device number 3 using dwc2
[ 828.151310] usb 1-1.2: reset high-speed USB device number 3 using dwc2
[ 830.991241] usb 1-1.2: reset high-speed USB device number 3 using dwc2
Fixes: 2eb79a4d15ff ("ARM: dts: meson: enabling the USB Host controller on Odroid-C1/C1+ board")
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Kevin Hilman <khilman@baylibre.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
Changes from previous patch.
Fix the subject and commit message as per Martin's request
--Add the signal name in the comment
--Replace vbus-supply with phy-supply linking the power supply to phy node as pointed by Marine
which a PWREN signal in the USB_HOST controller (usb1)
USB_VBUS 4 2 0 unknown 5000mV 0mA 5000mV 5000mV
phy-c1108820.phy.1 2 0mA 0mV 0mV
phy-c1108800.phy.0 2 0mA 0mV 0mV
---
arch/arm/boot/dts/meson8b-odroidc1.dts | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts
index 58669abda259..bfa472a679d9 100644
--- a/arch/arm/boot/dts/meson8b-odroidc1.dts
+++ b/arch/arm/boot/dts/meson8b-odroidc1.dts
@@ -83,6 +83,22 @@
regulator-max-microvolt = <5000000>;
};
+ usb_vbus: regulator-usb-vbus {
+ compatible = "regulator-fixed";
+
+ regulator-name = "USB_VBUS";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+
+ vin-supply = <&p5v0>;
+
+ /*
+ * signal name from schematics: PWREN
+ */
+ gpio = <&gpio_ao GPIOAO_5 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
tflash_vdd: regulator-tflash_vdd {
/*
* signal name from schematics: TFLASH_VDD_EN
@@ -295,8 +311,18 @@
pinctrl-names = "default";
};
+&usb0_phy {
+ status = "okay";
+ phy-supply = <&usb_vbus>;
+};
+
&usb1_phy {
status = "okay";
+ phy-supply = <&usb_vbus>;
+};
+
+&usb0 {
+ status = "okay";
};
&usb1 {
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-23 15:13 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 15:12 [RFCv1 0/3] Odroid c1+ usb fixs Anand Moon
2019-01-23 15:12 ` [RFCv1 1/3] phy: meson8b-usb2: Enable otg phy controller on Meson8b SoCs Anand Moon
2019-02-04 13:20 ` Martin Blumenstingl
2019-02-04 20:02 ` Anand Moon
2019-02-04 20:26 ` Martin Blumenstingl
2019-02-05 19:52 ` Anand Moon
2019-02-06 11:48 ` Martin Blumenstingl
2019-02-07 6:41 ` Anand Moon
2019-01-23 15:12 ` Anand Moon [this message]
2019-02-04 13:29 ` [RFCv1 2/3] ARM: dts: meson8b: odroidc1: fix USB power supplies for phy Martin Blumenstingl
2019-02-04 20:03 ` Anand Moon
2019-02-04 20:35 ` Martin Blumenstingl
2019-02-05 19:52 ` Anand Moon
2019-02-06 11:28 ` Martin Blumenstingl
2019-02-07 6:32 ` Anand Moon
2019-02-09 0:36 ` Martin Blumenstingl
2019-02-09 17:55 ` Anand Moon
2019-02-10 22:21 ` Martin Blumenstingl
2019-02-11 15:08 ` Anand Moon
2019-02-17 14:26 ` Martin Blumenstingl
2019-01-23 15:12 ` [RFCv1 3/3] ARM: dts: meson8b: odroidc1: enable the OTG capable USB controller Anand Moon
2019-02-04 13:51 ` [RFCv1 0/3] Odroid c1+ usb fixs Martin Blumenstingl
2019-02-04 20:04 ` Anand Moon
2019-02-04 20:38 ` Martin Blumenstingl
2019-02-05 19:53 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123151209.2080-3-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).