From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B05C43381 for ; Fri, 15 Mar 2019 13:25:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63EA8218A1 for ; Fri, 15 Mar 2019 13:25:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rGcDWkVZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63EA8218A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=81QVqFxZlJ14LXqB0JZ76dVOM2ooiWgxJPHesWmNy60=; b=rGcDWkVZ2Irm3WuUuYf5h2kNz 4ZYXC9wf+zu+gYThvUeaqmYdFZA5cdecxokmGLFp5Izm5q3jTK+OsBTnMHcbeMU8/txcytUaQxKQb szD370LcVDQuIoPVS0KVvPSAjv/zsXB/uqg6sgzLTrMw/4yMGFDE7t7V5lBmI4VH75HEkzzrgF9j0 PUn5slAEwURM8DgzUe0nDagV1Tp0dSA9KbahaRasn7UM1T1NM0X5ed5LMRuJLZdGrL5z2WoA3GYo5 egpuCpTdFle+30bxIzYEYuNDDxbj+ljoInwF+fdqDNlsZSu9LoNK0bulREHKg9XxRtsPnpybRMvf0 6SzEJsYRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4mqF-0005in-IR; Fri, 15 Mar 2019 13:25:43 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4mqC-0005i1-0S for linux-arm-kernel@lists.infradead.org; Fri, 15 Mar 2019 13:25:42 +0000 X-Originating-IP: 185.94.189.187 Received: from localhost (unknown [185.94.189.187]) (Authenticated sender: maxime.ripard@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id DEA8B20019; Fri, 15 Mar 2019 13:25:25 +0000 (UTC) Date: Fri, 15 Mar 2019 14:25:25 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH 6/6] arm64: dts: allwinner: bananapi-m64: Enable S070WV20-CT16 DSI panel Message-ID: <20190315132525.te3vaiukcniavaz2@flea> References: <20190315130825.9005-1-jagan@amarulasolutions.com> <20190315130825.9005-7-jagan@amarulasolutions.com> MIME-Version: 1.0 In-Reply-To: <20190315130825.9005-7-jagan@amarulasolutions.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190315_062540_354130_C9F7E4C6 X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Chen-Yu Tsai , Rob Herring , Laurent Pinchart , Daniel Vetter , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============3089393051899817882==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3089393051899817882== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dgz7eolxcwybvexh" Content-Disposition: inline --dgz7eolxcwybvexh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 15, 2019 at 06:38:25PM +0530, Jagan Teki wrote: > This patch add support for Bananapi S070WV20-CT16 DSI panel to > BPI-M64 board. >=20 > Bananapi S070WV20-CT16 is a pure RGB output panel with ICN6211 DSI/RGB > convertor bridge, so enable bridge along with associated panel. >=20 > DSI panel connected via board DSI port with, > - DLDO1 as VCC-DSI supply > - PD6 gpio for reset pin > - PD5 gpio for backlight enable pin > - PD7 gpio for backlight vdd supply >=20 > Signed-off-by: Jagan Teki > --- > .../dts/allwinner/sun50i-a64-bananapi-m64.dts | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/= arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > index 7793ebb5d2b8..f31083aa4521 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts > @@ -45,6 +45,7 @@ > #include "sun50i-a64.dtsi" > =20 > #include > +#include > =20 > / { > model =3D "BananaPi-M64"; > @@ -56,6 +57,15 @@ > serial1 =3D &uart1; > }; > =20 > + backlight: backlight { > + compatible =3D "pwm-backlight"; > + pwms =3D <&r_pwm 0 50000 PWM_POLARITY_INVERTED>; > + brightness-levels =3D <1 2 4 8 16 32 64 128 512>; > + default-brightness-level =3D <2>; > + enable-gpios =3D <&pio 3 5 GPIO_ACTIVE_HIGH>; /* LCD-BL-EN: PD5 */ > + power-supply =3D <®_vdd_backlight>; > + }; > + > chosen { > stdout-path =3D "serial0:115200n8"; > }; > @@ -91,6 +101,26 @@ > }; > }; > =20 > + panel-connector { > + compatible =3D "bananapi,s070wv20-ct16", "simple-panel"; > + > + port { > + backlight =3D <&backlight>; > + panel_ep: endpoint { > + remote-endpoint =3D <&bridge_out_ep>; > + }; > + }; > + }; > + > + reg_vdd_backlight: vdd-backlight { > + compatible =3D "regulator-fixed"; > + regulator-name =3D "vdd-backlight"; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + gpio =3D <&pio 3 7 GPIO_ACTIVE_HIGH>; /* LCD-PWR-EN: PD7 */ > + enable-active-high; > + }; > + > wifi_pwrseq: wifi_pwrseq { > compatible =3D "mmc-pwrseq-simple"; > reset-gpios =3D <&r_pio 0 2 GPIO_ACTIVE_LOW>; /* PL2 */ > @@ -116,6 +146,33 @@ > status =3D "okay"; > }; > =20 > +&dphy { > + status =3D "okay"; > +}; > + > +&dsi { > + vcc-dsi-supply =3D <®_dldo1>; /* VCC3V3-DSI */ > + status =3D "okay"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + bridge@0 { > + compatible =3D "bananapi,icn6211", "chipone, icn6211"; There's a typo in the compatible > + reg =3D <0>; > + reset-gpios =3D <&pio 3 6 GPIO_ACTIVE_HIGH>; /* LCD-RST: PD6 */ > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + port@1 { > + reg =3D <1>; > + > + bridge_out_ep: endpoint { > + remote-endpoint =3D <&panel_ep>; > + }; > + }; The port here should be under a node called ports, with two ports, which is what you documented in your binding. Maxime --=20 Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --dgz7eolxcwybvexh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXIunxQAKCRDj7w1vZxhR xYM6AP0SIg/izMSRFCknAA3uUJaO1O5Rcrbsj80n/CLeLI7QdgD/evp8LOuxuY4O 5oK17zZM11/DgJ4kx0mwDAB8k7QENQk= =+9NT -----END PGP SIGNATURE----- --dgz7eolxcwybvexh-- --===============3089393051899817882== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3089393051899817882==--