From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
suzuki.poulose@arm.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
mingo@redhat.com, jolsa@redhat.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] perf tools: Properly set the value of 'old' and 'head' in snapshot mode
Date: Sun, 9 Jun 2019 14:51:01 +0800 [thread overview]
Message-ID: <20190609065101.GA6357@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20190607182325.GL21245@kernel.org>
Hi Arnaldo,
On Fri, Jun 07, 2019 at 03:23:25PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 07, 2019 at 02:44:25PM +0800, Leo Yan escreveu:
> > On Thu, Jun 06, 2019 at 05:10:56PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Wed, Jun 05, 2019 at 10:16:33AM -0600, Mathieu Poirier escreveu:
> > > > This patch adds the necessay intelligence to properly compute the value
> > > > of 'old' and 'head' when operating in snapshot mode. That way we can get
> > > > the latest information in the AUX buffer and be compatible with the
> > > > generic AUX ring buffer mechanic.
> > >
> > > Leo, have you had the chance to test/review this one? Suzuki?
> >
> > Sure. I applied this patch on the perf/core branch (with latest
> > commit 3e4fbf36c1e3 'perf augmented_raw_syscalls: Move reading
> > filename to the loop') and passed testing with below steps:
> >
> > # perf record -e cs_etm/@tmc_etr0/ -S -m,64 --per-thread ./sort &
> > [1] 19097
> > Bubble sorting array of 30000 elements
> >
> > # kill -USR2 19097
> > # kill -USR2 19097
> > # kill -USR2 19097
> > [ perf record: Woken up 4 times to write data ]
> > [ perf record: Captured and wrote 0.753 MB perf.data ]
> >
> > FWIW:
> >
> > Tested-by: Leo Yan <leo.yan@linaro.org>
>
> Thanks a lot, I've added your "Tester notes:" and also your Tested-by:.
>
> As I don't have hardware (yet) to test these patches, tests by people
> who can test on real hardware is always super appreciated.
You are very welcome and it's my pleasure :)
> Any suggestions for a SBC that I could buy to be able to do so?
Below are several Arm development boards for referrence:
- DB410c [1]: This board is the first choice for myself, since this
board provides Debian (and Fedora :) support and it supports the
mainline kernel pretty well; the CoreSight also is well supported.
This board is about 80 USD so the cost is not expensive; on the
other hand, please note one cons is the SDRAM is only 1GB, this will
be impossible if you build some big projects (e.g. LLVM/Clang and
BCC); but it's sufficient for perf related development and
verification.
- There have other several boards are in my mind:
Raspberry Pi3 [2] and Hikey960 [3].
Raspberry Pi3 misses some features in the mainline kernel [4] and it
has not enabled CoreSight hardware tracing feature; Hikey960 also
have some patches are out of the mainline kenrel.
Except you have special requirement (e.g. you want to use the board to
build LLVM/Clang/BCC with big DDR size, etc), these two boards can be
secondary choices.
Please feel free let me know if you have questions for boards.
Thanks,
Leo Yan
[1] https://www.96boards.org/product/dragonboard410c/
[2] https://www.raspberrypi.org/products/raspberry-pi-3-model-b-plus/
[3] https://www.96boards.org/product/hikey960/
[4] https://www.raspberrypi.org/forums/viewtopic.php?t=236568
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-09 6:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 16:16 [PATCH] perf tools: Properly set the value of 'old' and 'head' in snapshot mode Mathieu Poirier
2019-06-06 20:10 ` Arnaldo Carvalho de Melo
2019-06-07 6:44 ` Leo Yan
2019-06-07 18:23 ` Arnaldo Carvalho de Melo
2019-06-09 6:51 ` Leo Yan [this message]
2019-06-07 14:44 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190609065101.GA6357@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).