From: Niklas Cassel <niklas.cassel@linaro.org>
To: Andy Gross <agross@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, arm@kernel.org,
linux-arm-kernel@lists.infradead.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH] arm64: qcom: qcs404: Add reset-cells to GCC node
Date: Mon, 10 Jun 2019 10:17:01 +0200 [thread overview]
Message-ID: <20190610081701.GA3152@centauri> (raw)
In-Reply-To: <1560053972-32273-1-git-send-email-agross@kernel.org>
On Sat, Jun 08, 2019 at 11:19:32PM -0500, Andy Gross wrote:
> This patch adds a reset-cells property to the gcc controller on the QCS404.
> Without this in place, we get warnings like the following if nodes reference
> a gcc reset:
>
> arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property):
> /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node
> /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0])
> also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3
> DTC arch/arm64/boot/dts/qcom/qcs404-evb-4000.dtb
> arch/arm64/boot/dts/qcom/qcs404.dtsi:261.38-310.5: Warning (resets_property):
> /soc@0/remoteproc@b00000: Missing property '#reset-cells' in node
> /soc@0/clock-controller@1800000 or bad phandle (referred from resets[0])
> also defined at arch/arm64/boot/dts/qcom/qcs404-evb.dtsi:82.18-84.3
>
> Signed-off-by: Andy Gross <agross@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index 342788a..086cadb 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -426,6 +426,7 @@
> compatible = "qcom,gcc-qcs404";
> reg = <0x01800000 0x80000>;
> #clock-cells = <1>;
> + #reset-cells = <1>;
>
> assigned-clocks = <&gcc GCC_APSS_AHB_CLK_SRC>;
> assigned-clock-rates = <19200000>;
> --
> 2.7.4
>
Reviewed-by: Niklas Cassel <niklas.cassel@linaro.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-10 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 4:19 [PATCH] arm64: qcom: qcs404: Add reset-cells to GCC node Andy Gross
2019-06-10 8:17 ` Niklas Cassel [this message]
2019-06-10 15:58 ` Vinod Koul
2019-06-19 13:17 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610081701.GA3152@centauri \
--to=niklas.cassel@linaro.org \
--cc=agross@kernel.org \
--cc=arm@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).