From: Kees Cook <keescook@chromium.org>
To: Jann Horn <jannh@google.com>
Cc: Kernel Hardening <kernel-hardening@lists.openwall.com>,
Russell King <linux@armlinux.org.uk>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Emese Revfy <re.emese@gmail.com>,
Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] security: do not enable CONFIG_GCC_PLUGINS by default
Date: Fri, 14 Jun 2019 20:08:42 -0700 [thread overview]
Message-ID: <201906142002.833D224C6F@keescook> (raw)
In-Reply-To: <CAG48ez30+VOj78rCiWMKtm0tHdVR67CcrHVCV-FFCfK-nRQTOw@mail.gmail.com>
On Fri, Jun 14, 2019 at 06:05:19PM +0200, Jann Horn wrote:
> On Fri, Jun 14, 2019 at 5:10 PM Denis 'GNUtoo' Carikli
> <GNUtoo@cyberdimension.org> wrote:
> > Booting was broken by the following commit:
> > 9f671e58159a ("security: Create "kernel hardening" config area")
>
> I don't think GCC_PLUGINS alone is supposed to generate any code? It
> just makes it possible to enable a bunch of other kconfig flags that
> can generate code.
>
> STACKPROTECTOR_PER_TASK defaults to y and depends on GCC_PLUGINS, so
> is that perhaps what broke? Can you try whether disabling just that
> works for you?
Yes, this has come up before: the option you want to disable is as Jann
mentions: CONFIG_STACKPROTECTOR_PER_TASK.
> My guess is that maybe there is some early boot code that needs to
> have the stack protector disabled, or something like that.
Right, though I'm not sure what portion would be specific to that
device. You can turn off SSP on a per-file basis with:
CFLAGS_target.o += $(DISABLE_ARM_SSP_PER_TASK_PLUGIN)
or per-Makefile, as in arch/arm/boot/compressed/Makefile.
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-06-15 3:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190614145755.10926-1-GNUtoo@cyberdimension.org>
2019-06-14 16:05 ` [PATCH] security: do not enable CONFIG_GCC_PLUGINS by default Jann Horn
2019-06-14 16:12 ` Denis 'GNUtoo' Carikli
2019-06-14 16:28 ` Russell King - ARM Linux admin
2019-06-14 18:14 ` Denis 'GNUtoo' Carikli
2019-06-14 18:54 ` Russell King - ARM Linux admin
2019-06-15 10:13 ` Paul Kocialkowski
2019-06-21 23:42 ` Denis 'GNUtoo' Carikli
2019-06-24 13:31 ` Paul Kocialkowski
2019-06-15 3:08 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201906142002.833D224C6F@keescook \
--to=keescook@chromium.org \
--cc=GNUtoo@cyberdimension.org \
--cc=jannh@google.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=paul.kocialkowski@bootlin.com \
--cc=re.emese@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).