From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hugues Fruchet <hugues.fruchet@st.com>
Cc: Yannick Fertre <yannick.fertre@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Mickael GUENE <mickael.guene@st.com>,
linux-kernel@vger.kernel.org,
Philippe CORNU <philippe.cornu@st.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 1/3] media: stm32-dcmi: improve sensor subdev naming
Date: Thu, 20 Jun 2019 18:26:41 +0300 [thread overview]
Message-ID: <20190620152640.chd4u4u5hd56ausk@kekkonen.localdomain> (raw)
In-Reply-To: <1560242912-17138-2-git-send-email-hugues.fruchet@st.com>
Hi Hugues,
On Tue, Jun 11, 2019 at 10:48:30AM +0200, Hugues Fruchet wrote:
> Add a new "sensor" field to dcmi struct instead of
> reusing entity->subdev to address sensor subdev.
The purpose of the struct binding image source's async subdev as well as
related information is to allow associating the two. This patch breaks
that. If your device can support a single sensor, it might not be a big
deal. The end result remains somewhat inconsistent as subdev specific
information is spread across struct stm32_dcmi and struct
dcmi_graph_entity.
In general you don't need to know the sensor as you can always find it
using media_entity_remote_pad(). This driver is a little different though
as it could presumably continue to work without MC. Was that the intent?
On a side note: struct dcmi_graph_entity does NOT have struct
v4l2_async_subdev as its first member. Please fix that and prepend the fix
to this set.
--
Kind regards,
Sakari Ailus
sakari.ailus@linux.intel.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-20 15:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 8:48 [PATCH v2 0/3] DCMI bridge support Hugues Fruchet
2019-06-11 8:48 ` [PATCH v2 1/3] media: stm32-dcmi: improve sensor subdev naming Hugues Fruchet
2019-06-20 15:26 ` Sakari Ailus [this message]
2019-07-02 15:21 ` Hugues FRUCHET
2019-06-11 8:48 ` [PATCH v2 2/3] media: stm32-dcmi: add media controller support Hugues Fruchet
2019-06-20 12:01 ` Hans Verkuil
2019-07-02 15:18 ` Hugues FRUCHET
2019-06-20 16:13 ` Sakari Ailus
2019-07-02 15:29 ` Hugues FRUCHET
2019-06-11 8:48 ` [PATCH v2 3/3] media: stm32-dcmi: add support of several sub-devices Hugues Fruchet
2019-06-20 15:54 ` Sakari Ailus
2019-07-02 15:26 ` Hugues FRUCHET
2019-06-20 16:17 ` [PATCH v2 0/3] DCMI bridge support Sakari Ailus
2019-06-24 10:10 ` Hugues FRUCHET
2019-06-26 17:25 ` Laurent Pinchart
2019-06-27 12:38 ` Hugues FRUCHET
2019-06-27 13:38 ` Laurent Pinchart
2019-07-05 7:55 ` Sakari Ailus
2019-07-05 8:04 ` Laurent Pinchart
2019-07-05 9:16 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620152640.chd4u4u5hd56ausk@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=hugues.fruchet@st.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mchehab@kernel.org \
--cc=mickael.guene@st.com \
--cc=philippe.cornu@st.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).