From: Jiri Olsa <jolsa@redhat.com>
To: John Garry <john.garry@huawei.com>
Cc: mark.rutland@arm.com, brueckner@linux.ibm.com,
mathieu.poirier@linaro.org, peterz@infradead.org,
tmricht@linux.ibm.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org, acme@kernel.org,
linuxarm@huawei.com, zhangshaokun@hisilicon.com,
alexander.shishkin@linux.intel.com, mingo@redhat.com,
namhyung@kernel.org, ben@decadent.org.uk,
linux-arm-kernel@lists.infradead.org, kan.liang@linux.intel.com
Subject: Re: [PATCH v2 2/5] perf pmu: Support more complex PMU event aliasing
Date: Thu, 20 Jun 2019 20:25:19 +0200 [thread overview]
Message-ID: <20190620182519.GA15239@krava> (raw)
In-Reply-To: <a27e65b4-b487-9206-6dd0-6f9dcec0f1f5@huawei.com>
On Mon, Jun 17, 2019 at 10:06:08AM +0100, John Garry wrote:
> On 16/06/2019 10:58, Jiri Olsa wrote:
> > On Fri, Jun 14, 2019 at 10:08:00PM +0800, John Garry wrote:
> > > The jevent "Unit" field is used for uncore PMU alias definition.
> > >
> > > The form uncore_pmu_example_X is supported, where "X" is a wildcard,
> > > to support multiple instances of the same PMU in a system.
> > >
> > > Unfortunately this format not suitable for all uncore PMUs; take the Hisi
> > > DDRC uncore PMU for example, where the name is in the form
> > > hisi_scclX_ddrcY.
> > >
> > > For the current jevent parsing, we would be required to hardcode an uncore
> > > alias translation for each possible value of X. This is not scalable.
> > >
> > > Instead, add support for "Unit" field in the form "hisi_sccl,ddrc", where
> > > we can match by hisi_scclX and ddrcY. Tokens in Unit field are
> > > delimited by ','.
> > >
> > > Signed-off-by: John Garry <john.garry@huawei.com>
> > > ---
> > > tools/perf/util/pmu.c | 39 ++++++++++++++++++++++++++++++++++-----
> > > 1 file changed, 34 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
> > > index 7e7299fee550..bc71c60589b5 100644
> > > --- a/tools/perf/util/pmu.c
> > > +++ b/tools/perf/util/pmu.c
> > > @@ -700,6 +700,39 @@ struct pmu_events_map *perf_pmu__find_map(struct perf_pmu *pmu)
> > > return map;
> > > }
> > >
> > > +static bool pmu_uncore_alias_match(const char *pmu_name, const char *name)
> > > +{
> > > + char *tmp, *tok, *str;
> > > + bool res;
> > > +
> > > + str = strdup(pmu_name);
> > > + if (!str)
> > > + return false;
> > > +
> > > + /*
> > > + * uncore alias may be from different PMU with common
> > > + * prefix or matching tokens.
> > > + */
> > > + tok = strtok_r(str, ",", &tmp);
> > > + if (strncmp(pmu_name, tok, strlen(tok))) {
> >
>
> Hi Jirka,
heya,
sry for late reply
>
> > if tok is NULL in here we crash
> >
>
> As I see, tok could not be NULL. If str contains no delimiters, then we just
> return same as str in tok.
>
> Can you see tok being NULL?
well, if there's no ',' in the str it returns NULL, right?
and IIUC this function is still called for standard uncore
pmu names
>
> > > + res = false;
> > > + goto out;
> > > + }
> > > +
> > > + for (; tok; name += strlen(tok), tok = strtok_r(NULL, ",", &tmp)) {
> >
> > why is name shifted in here?
>
> I want to ensure that we match the tokens in order and also guard against
> possible repeated token matches in 'name'.
i might not understand this correctly.. so
str is the alias name that can contain ',' now, like:
hisi_sccl,ddrc
and name is still pmu with no ',' ... please make this or
proper version that in some comment
thanks,
jirka
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-20 18:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 14:07 [PATCH v2 0/5] Perf uncore PMU event alias support for Hisi hip08 ARM64 platform John Garry
2019-06-14 14:07 ` [PATCH v2 1/5] perf pmu: Fix uncore PMU alias list for ARM64 John Garry
2019-06-14 14:46 ` Arnaldo Carvalho de Melo
2019-06-14 15:04 ` John Garry
2019-06-14 15:47 ` Arnaldo Carvalho de Melo
2019-06-14 14:08 ` [PATCH v2 2/5] perf pmu: Support more complex PMU event aliasing John Garry
2019-06-14 14:50 ` Arnaldo Carvalho de Melo
2019-06-16 9:58 ` Jiri Olsa
2019-06-17 9:06 ` John Garry
2019-06-20 18:25 ` Jiri Olsa [this message]
2019-06-21 10:42 ` John Garry
2019-06-27 16:27 ` John Garry
2019-06-27 16:33 ` Jiri Olsa
2019-06-28 10:40 ` Jiri Olsa
2019-06-28 10:45 ` John Garry
2019-06-14 14:08 ` [PATCH v2 3/5] perf jevents: Add support for Hisi hip08 DDRC PMU aliasing John Garry
2019-06-14 14:08 ` [PATCH v2 4/5] perf jevents: Add support for Hisi hip08 HHA " John Garry
2019-06-14 14:08 ` [PATCH v2 5/5] perf jevents: Add support for Hisi hip08 L3C " John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620182519.GA15239@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ben@decadent.org.uk \
--cc=brueckner@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
--cc=will.deacon@arm.com \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).