From: Angelo Dureghello <angelo@sysam.it>
To: yibin.gong@nxp.com
Cc: mark.rutland@arm.com, robh@kernel.org,
devicetree@vger.kernel.org, festevam@gmail.com,
s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
vkoul@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
dmaengine@vger.kernel.org, dan.j.williams@intel.com,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 0/6] add edma2 for i.mx7ulp
Date: Tue, 25 Jun 2019 22:56:17 +0200 [thread overview]
Message-ID: <20190625205617.GA24968@jerusalem> (raw)
In-Reply-To: <20190625094324.19196-1-yibin.gong@nxp.com>
Hi Robin,
On Tue, Jun 25, 2019 at 05:43:18PM +0800, yibin.gong@nxp.com wrote:
> From: Robin Gong <yibin.gong@nxp.com>
>
> This patch set add new version of edma for i.mx7ulp, the main changes
> are as belows:
> 1. only one dmamux.
> 2. another clock dma_clk except dmamux clk.
> 3. 16 independent interrupts instead of only one interrupt for
> all channels
> For the first change, need modify fsl-edma-common.c and mcf-edma,
> so create the first two patches to prepare without any function impact.
>
> For the third change, need request single irq for every channel with
> the legacy handler. But actually 2 dma channels share one interrupt(16
> channel interrupts, but 32 channels.),ch0/ch16,ch1/ch17... For now, just
> simply request irq without IRQF_SHARED flag, since 16 channels are enough
> on i.mx7ulp whose M4 domain own some peripherals.
>
> change from v1:
> 1. check .data of 'of_device_id' in probe instead of compatible name.
>
> change from v2:
> 1. move the difference between edma and edma2 into driver data so that
> no need version checking in fsl-edma.c.
>
> change from v3:
> 1. remove duplicated 'version' and 'dmamux_nr' in 'struct fsl_edma_engine'
> since they are included in drvdata already.
> 2. downgrade print log level.
> 3. address some minor indent issues raised by Vinod.
>
> change from v4:
> 1. correct typo.
>
> Robin Gong (6):
> dmaengine: fsl-edma: add drvdata for fsl-edma
> dmaengine: fsl-edma-common: move dmamux register to another single
> function
> dmaengine: fsl-edma-common: version check for v2 instead
> dt-bindings: dma: fsl-edma: add new i.mx7ulp-edma
> dmaengine: fsl-edma: add i.mx7ulp edma2 version support
> ARM: dts: imx7ulp: add edma device node
>
> Documentation/devicetree/bindings/dma/fsl-edma.txt | 44 ++++++++-
> arch/arm/boot/dts/imx7ulp.dtsi | 28 ++++++
> drivers/dma/fsl-edma-common.c | 83 ++++++++++------
> drivers/dma/fsl-edma-common.h | 14 ++-
> drivers/dma/fsl-edma.c | 109 ++++++++++++++++++---
> drivers/dma/mcf-edma.c | 11 ++-
> 6 files changed, 239 insertions(+), 50 deletions(-)
>
I tested the patch-set on ColdFire mcf5441x (stmark2 board), all works fine.
Tested-by: Angelo Dureghello <angelo@sysam.it>
Regards,
Angelo
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-25 20:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 9:43 [PATCH v5 0/6] add edma2 for i.mx7ulp yibin.gong
2019-06-25 9:43 ` [PATCH v5 1/6] dmaengine: fsl-edma: add drvdata for fsl-edma yibin.gong
2019-06-25 9:43 ` [PATCH v5 2/6] dmaengine: fsl-edma-common: move dmamux register to another single function yibin.gong
2019-06-25 9:43 ` [PATCH v5 3/6] dmaengine: fsl-edma-common: version check for v2 instead yibin.gong
2019-06-25 9:43 ` [PATCH v5 4/6] dt-bindings: dma: fsl-edma: add new i.mx7ulp-edma yibin.gong
2019-06-25 9:43 ` [PATCH v5 5/6] dmaengine: fsl-edma: add i.mx7ulp edma2 version support yibin.gong
2019-06-25 9:43 ` [PATCH v5 6/6] ARM: dts: imx7ulp: add edma device node yibin.gong
2019-07-18 2:49 ` Shawn Guo
2019-06-25 20:56 ` Angelo Dureghello [this message]
2019-07-03 7:58 ` [PATCH v5 0/6] add edma2 for i.mx7ulp Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625205617.GA24968@jerusalem \
--to=angelo@sysam.it \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).