From: Will Deacon <will@kernel.org>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Nick Desaulniers <ndesaulniers@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Will Deacon <will.deacon@arm.com>, Qian Cai <cai@lca.pw>,
Thomas Gleixner <tglx@linutronix.de>,
Nathan Chancellor <natechancellor@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build
Date: Wed, 26 Jun 2019 10:38:37 +0100 [thread overview]
Message-ID: <20190626093836.y2lofo54rhxw3xsm@willie-the-truck> (raw)
In-Reply-To: <193c179e-16ca-4b4e-2584-75e8f6c1819f@arm.com>
On Tue, Jun 25, 2019 at 06:00:27PM +0100, Vincenzo Frascino wrote:
> On 25/06/2019 17:26, Nick Desaulniers wrote:
> > On Tue, Jun 25, 2019 at 7:54 AM Vincenzo Frascino
> > <vincenzo.frascino@arm.com> wrote:
> >>> but clang 7.0 is still use in many distros by default, so maybe this commit can
> >>> be fixed by adding a conditional check to use "small" if clang version < 8.0.
> >>>
> >>
> >> Could you please verify that the patch below works for you?
> >
> > Should it be checking against CONFIG_CLANG_VERSION, or better yet be
> > using cc-option macro?
> >
>
> This is what I did in my proposed patch, but I was surprised that clang-7
> generates relocations that clang-8 does not.
>
> LD arch/arm64/kernel/vdso/vdso.so.dbg
> VDSOCHK arch/arm64/kernel/vdso/vdso.so.dbg
> 00000000000009d0 R_AARCH64_JUMP_SLOT _mcount
Hmm. It would be nice to understand where the reference to _mcount is coming
from, since that sounds like ftrace is getting involved where it shouldn't
be.
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-26 9:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 12:16 "arm64: vdso: Substitute gettimeofday() with C implementation" breaks clang build Qian Cai
2019-06-25 12:47 ` Vincenzo Frascino
2019-06-25 12:56 ` Qian Cai
2019-06-25 13:40 ` Vincenzo Frascino
2019-06-25 13:51 ` Qian Cai
2019-06-25 14:11 ` Vincenzo Frascino
2019-06-25 14:28 ` Qian Cai
2019-06-25 14:30 ` Vincenzo Frascino
2019-06-25 14:54 ` Vincenzo Frascino
2019-06-25 15:16 ` Qian Cai
2019-06-25 16:26 ` Nick Desaulniers
2019-06-25 17:00 ` Vincenzo Frascino
2019-06-25 17:31 ` Qian Cai
2019-06-25 17:33 ` Vincenzo Frascino
2019-06-26 9:38 ` Will Deacon [this message]
2019-06-26 9:45 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626093836.y2lofo54rhxw3xsm@willie-the-truck \
--to=will@kernel.org \
--cc=cai@lca.pw \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).