From: Sean Paul <sean@poorly.run>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "David Airlie" <airlied@linux.ie>,
"Liviu Dudau" <Liviu.Dudau@arm.com>,
dri-devel@lists.freedesktop.org,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Eric Anholt" <eric@anholt.net>, "Rob Herring" <robh@kernel.org>,
"Stefan Agner" <stefan@agner.ch>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
"CK Hu" <ck.hu@mediatek.com>,
"Thierry Reding" <treding@nvidia.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Chunming Zhou" <david1.zhou@amd.com>,
"Jani Nikula" <jani.nikula@intel.com>,
"Intel Graphics Development" <intel-gfx@lists.freedesktop.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
linux-mediatek@lists.infradead.org,
"Lionel Landwerlin" <lionel.g.landwerlin@intel.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Sean Paul" <sean@poorly.run>,
linux-arm-kernel@lists.infradead.org,
"Boris Brezillon" <bbrezillon@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Rob Clark" <robdclark@gmail.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH v1 04/11] drm/ati_pcigart: drop dependency on drm_os_linux.h
Date: Thu, 18 Jul 2019 13:49:05 -0400 [thread overview]
Message-ID: <20190718174905.GG31819@art_vandelay> (raw)
In-Reply-To: <20190718161507.2047-5-sam@ravnborg.org>
On Thu, Jul 18, 2019 at 06:15:00PM +0200, Sam Ravnborg wrote:
> The drm_os_linux.h header is deprecated.
> Just opencode the sole DRM_WRITE32().
Any plans for the other users of DRM_WRITE<N>()? It seems like it'd be trivial
to fix it up for via and mga. I don't really have any background on
drm_os_linux.h, but it doesn't seem like it'd be that much more effort to just
remove the whole thing.
Sean
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> ---
> drivers/gpu/drm/ati_pcigart.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/ati_pcigart.c b/drivers/gpu/drm/ati_pcigart.c
> index 2a413e291a60..580aa2676358 100644
> --- a/drivers/gpu/drm/ati_pcigart.c
> +++ b/drivers/gpu/drm/ati_pcigart.c
> @@ -35,7 +35,6 @@
>
> #include <drm/ati_pcigart.h>
> #include <drm/drm_device.h>
> -#include <drm/drm_os_linux.h>
> #include <drm/drm_pci.h>
> #include <drm/drm_print.h>
>
> @@ -169,6 +168,7 @@ int drm_ati_pcigart_init(struct drm_device *dev, struct drm_ati_pcigart_info *ga
> page_base = (u32) entry->busaddr[i];
>
> for (j = 0; j < (PAGE_SIZE / ATI_PCIGART_PAGE_SIZE); j++) {
> + u32 offset;
> u32 val;
>
> switch(gart_info->gart_reg_if) {
> @@ -184,10 +184,12 @@ int drm_ati_pcigart_init(struct drm_device *dev, struct drm_ati_pcigart_info *ga
> break;
> }
> if (gart_info->gart_table_location ==
> - DRM_ATI_GART_MAIN)
> + DRM_ATI_GART_MAIN) {
> pci_gart[gart_idx] = cpu_to_le32(val);
> - else
> - DRM_WRITE32(map, gart_idx * sizeof(u32), val);
> + } else {
> + offset = gart_idx * sizeof(u32);
> + writel(val, (void __iomem *)map->handle + offset);
> + }
> gart_idx++;
> page_base += ATI_PCIGART_PAGE_SIZE;
> }
> --
> 2.20.1
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-18 17:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 16:14 [PATCH v1 0/11] drm: header maintenance Sam Ravnborg
2019-07-18 16:14 ` [PATCH v1 01/11] drm/panel: make drm_panel.h self-contained Sam Ravnborg
2019-07-18 17:36 ` Sean Paul
2019-07-18 16:14 ` [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h Sam Ravnborg
2019-07-18 16:46 ` Chris Wilson
2019-07-19 6:54 ` Koenig, Christian
2019-07-29 12:45 ` Jani Nikula
2019-07-29 14:35 ` Sam Ravnborg
2019-07-29 15:28 ` Koenig, Christian
2019-07-29 17:50 ` Sam Ravnborg
2019-08-02 13:48 ` [Intel-gfx] " Jani Nikula
2019-08-02 15:28 ` Sam Ravnborg
2019-07-18 17:40 ` Sean Paul
2019-07-18 16:14 ` [PATCH v1 03/11] drm: drop uapi dependency from drm_vblank.h Sam Ravnborg
2019-07-18 17:41 ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 04/11] drm/ati_pcigart: drop dependency on drm_os_linux.h Sam Ravnborg
2019-07-18 17:49 ` Sean Paul [this message]
2019-07-18 18:11 ` Sam Ravnborg
2019-07-18 18:30 ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 05/11] drm/vblank: drop use of DRM_WAIT_ON() Sam Ravnborg
2019-07-18 17:50 ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 06/11] drm: direct include of drm.h in drm_gem.c Sam Ravnborg
2019-07-18 17:51 ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 07/11] drm: direct include of drm.h in drm_gem_shmem_helper.c Sam Ravnborg
2019-07-18 17:51 ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 08/11] drm: direct include of drm.h in drm_prime.c Sam Ravnborg
2019-07-18 17:51 ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 09/11] drm: direct include of drm.h in drm_syncobj.c Sam Ravnborg
2019-07-18 17:51 ` Sean Paul
2019-07-18 16:15 ` [PATCH v1 10/11] drm/mediatek: direct include of drm.h in mtk_drm_gem.c Sam Ravnborg
2019-07-18 17:52 ` Sean Paul
2019-07-19 1:30 ` CK Hu
2019-07-19 1:34 ` CK Hu
2019-07-18 16:15 ` [PATCH v1 11/11] drm: drop uapi dependency from drm_file.h Sam Ravnborg
2019-07-18 18:40 ` Sean Paul
2019-07-19 6:56 ` Koenig, Christian
2019-07-19 11:08 ` Sam Ravnborg
2019-07-19 21:26 ` [PATCH v1 0/11] drm: header maintenance Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718174905.GG31819@art_vandelay \
--to=sean@poorly.run \
--cc=Liviu.Dudau@arm.com \
--cc=airlied@linux.ie \
--cc=bbrezillon@kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=christian.koenig@amd.com \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=david1.zhou@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lionel.g.landwerlin@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@bootlin.com \
--cc=noralf@tronnes.org \
--cc=p.zabel@pengutronix.de \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=stefan@agner.ch \
--cc=treding@nvidia.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).