linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Emmanuel Vadot <manu@bidouilliste.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	"Jared D . McNeill" <jmcneill@NetBSD.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
	Harald Geyer <harald@ccbib.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: allwinner: a64: Drop PMU node
Date: Tue, 6 Aug 2019 21:10:07 +0200	[thread overview]
Message-ID: <20190806211007.cd9c10bd0d174f56e4998980@bidouilliste.com> (raw)
In-Reply-To: <20190806140135.4739-1-anarsoul@gmail.com>

On Tue,  6 Aug 2019 07:01:35 -0700
Vasily Khoruzhick <anarsoul@gmail.com> wrote:

> Looks like PMU in A64 is broken, it generates no interrupts at all and
> as result 'perf top' shows no events.
> 
> Tested on Pine64-LTS.
> 
> Fixes: 34a97fcc71c2 ("arm64: dts: allwinner: a64: Add PMU node")
> Cc: Harald Geyer <harald@ccbib.org>
> Cc: Jared D. McNeill <jmcneill@NetBSD.org>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 9cc9bdde81ac..cd92f546c483 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -142,15 +142,6 @@
>  		clock-output-names = "ext-osc32k";
>  	};
>  
> -	pmu {
> -		compatible = "arm,cortex-a53-pmu";
> -		interrupts = <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>,
> -			     <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
> -			     <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>,
> -			     <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>;
> -		interrupt-affinity = <&cpu0>, <&cpu1>, <&cpu2>, <&cpu3>;
> -	};
> -
>  	psci {
>  		compatible = "arm,psci-0.2";
>  		method = "smc";
> -- 
> 2.22.0

 It doesn't work for me too on FreeBSD, and yes the interrupts are
wrong but this is not the problem. Maybe there is a reset line but it's
not documented in the documentation.

 Reviewed-by: Emmanuel Vadot <manu@FreeBSD.org>

-- 
Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2019-08-06 19:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 14:01 [PATCH] arm64: dts: allwinner: a64: Drop PMU node Vasily Khoruzhick
2019-08-06 14:35 ` Robin Murphy
2019-08-06 14:45   ` Vasily Khoruzhick
2019-08-06 20:19     ` Harald Geyer
2019-08-06 20:52       ` Vasily Khoruzhick
2019-08-06 21:14         ` Robin Murphy
2019-08-07  2:39           ` Vasily Khoruzhick
2019-08-07 11:56             ` Maxime Ripard
2019-08-07 17:36               ` Vasily Khoruzhick
2019-08-08 16:26                 ` Maxime Ripard
2019-08-08 19:59                   ` Vasily Khoruzhick
2019-08-12  8:04                     ` Maxime Ripard
2019-08-12 18:01                       ` Vasily Khoruzhick
2019-08-12 18:22                         ` Harald Geyer
2019-08-13  5:39                         ` Maxime Ripard
2019-09-23 23:51                           ` Vasily Khoruzhick
2019-09-23 23:55                             ` Vasily Khoruzhick
2019-09-25 11:08                               ` Maxime Ripard
2019-10-31 19:10                                 ` Clément Péron
2019-10-31 20:35                                   ` Vasily Khoruzhick
2019-11-01 11:30                                     ` Clément Péron
2019-11-01 15:47                                       ` Andre Przywara
2019-11-11  1:43                                         ` André Przywara
2019-08-07 11:59             ` Robin Murphy
2019-08-07 11:12           ` Mark Rutland
2019-08-06 19:10 ` Emmanuel Vadot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190806211007.cd9c10bd0d174f56e4998980@bidouilliste.com \
    --to=manu@bidouilliste.com \
    --cc=anarsoul@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=harald@ccbib.org \
    --cc=jmcneill@NetBSD.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).